Skip to content

Conversation

@skipper-vp
Copy link
Contributor

@skipper-vp skipper-vp commented May 16, 2025

Updated TWIG CS fixer class.

Summary by CodeRabbit

  • Chores
    • Updated internal configuration to reference updated rule namespaces for improved consistency. No changes to user-facing functionality.

@coderabbitai
Copy link

coderabbitai bot commented May 16, 2025

📝 Walkthrough

Walkthrough

The changes update the namespace for two rules, HashQuoteRule and SingleQuoteRule, from TwigCsFixer\Rules\String to TwigCsFixer\Rules\Literal in configuration files. No other logic, configuration, or exported entities are modified.

Changes

File(s) Change Summary
.twig-cs-fixer.php, .vortex/installer/tests/Fixtures/install/_baseline/.twig-cs-fixer.php Updated the namespace for HashQuoteRule and SingleQuoteRule from TwigCsFixer\Rules\String to TwigCsFixer\Rules\Literal.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9dd765e and cd43410.

📒 Files selected for processing (2)
  • .twig-cs-fixer.php (1 hunks)
  • .vortex/installer/tests/Fixtures/install/_baseline/.twig-cs-fixer.php (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (12)
  • GitHub Check: build (1)
  • GitHub Check: build (0)
  • GitHub Check: vortex-test-workflow (3)
  • GitHub Check: vortex-test-workflow (2)
  • GitHub Check: vortex-test-workflow (1)
  • GitHub Check: vortex-test-deployment (1)
  • GitHub Check: vortex-test-workflow (0)
  • GitHub Check: vortex-test-deployment (0)
  • GitHub Check: vortex-test-installer (8.4)
  • GitHub Check: vortex-test-common
  • GitHub Check: vortex-test-installer (8.3)
  • GitHub Check: vortex-test-installer (8.2)
🔇 Additional comments (1)
.vortex/installer/tests/Fixtures/install/_baseline/.twig-cs-fixer.php (1)

14-15:

Details

❓ Verification inconclusive

Update rule namespaces to Literal
The HashQuoteRule and SingleQuoteRule have been moved from the TwigCsFixer\Rules\String namespace to TwigCsFixer\Rules\Literal to stay in sync with the core config. Ensure these classes are defined in the Literal namespace and that your autoloader can locate them.


🏁 Script executed:

#!/bin/bash
# Verify that the Literal namespace classes exist
rg -R 'namespace TwigCsFixer\\Rules\\Literal' -n
rg -R 'class HashQuoteRule' -n
rg -R 'class SingleQuoteRule' -n

Length of output: 1333


Here’s a corrected verification script to locate the classes under the Literal namespace:


🏁 Script executed:

#!/bin/bash
# Search for the Literal namespace and rule classes
rg 'namespace TwigCsFixer\\Rules\\Literal' -n .
rg 'class HashQuoteRule' -n .
rg 'class SingleQuoteRule' -n .

Length of output: 115


Let’s check if these rules still live under String or any other namespace:


🏁 Script executed:

#!/bin/bash
# List all TwigCsFixer\Rules namespaces and locate the QuoteRule classes
rg 'namespace TwigCsFixer\\Rules' -n .
rg 'class HashQuoteRule' -n .
rg 'class SingleQuoteRule' -n .

Length of output: 106


Update rule namespaces to Literal and confirm class availability
The HashQuoteRule and SingleQuoteRule have been relocated from TwigCsFixer\Rules\String to TwigCsFixer\Rules\Literal in the latest core config. Since these classes live in the external twig-cs-fixer package (not in this repo), please verify that:

  • Your installed twig-cs-fixer version defines
    TwigCsFixer\Rules\Literal\HashQuoteRule
    and
    TwigCsFixer\Rules\Literal\SingleQuoteRule.
  • Your autoloader is configured so these classes can be located at runtime.
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot temporarily deployed to commit May 16, 2025 01:05 Inactive
@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.56%. Comparing base (9dd765e) to head (cd43410).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1648   +/-   ##
========================================
  Coverage    71.56%   71.56%           
========================================
  Files           76       76           
  Lines         4308     4308           
========================================
  Hits          3083     3083           
  Misses        1225     1225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@skipper-vp skipper-vp requested a review from AlexSkrypnyk May 16, 2025 01:29
@skipper-vp skipper-vp added the Needs review Pull request needs a review from assigned developers label May 16, 2025
@AlexSkrypnyk AlexSkrypnyk merged commit 1c96ccd into develop May 16, 2025
29 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the updating-twig-cs-fixer branch May 16, 2025 01:42
@github-project-automation github-project-automation bot moved this from BACKLOG to Release queue in Vortex May 16, 2025
@AlexSkrypnyk AlexSkrypnyk moved this from Release queue to Released in 25.6.0 in Vortex Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs review Pull request needs a review from assigned developers

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants