Fixed Renovate config. #1686
Fixed Renovate config. #1686
Conversation
WalkthroughThe updates adjust CI/CD configurations by changing the Docker image version for Renovate in CircleCI, inserting a Node.js setup step (v22.16.0) before the Renovate config validator in GitHub Actions workflows, adding a Renovate config validation step to a common test workflow, explicitly specifying Node.js version in multiple workflows, and updating the default email address for the Renovate bot in a test fixture. No changes to public entities or application logic were made. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant actions/checkout
participant actions/setup-node
participant renovate-config-validator
participant Renovate Bot
GitHub Actions->>actions/checkout: Checkout code
GitHub Actions->>actions/setup-node: Setup Node.js (v22.16.0)
GitHub Actions->>renovate-config-validator: Validate Renovate config
GitHub Actions->>Renovate Bot: Run Renovate
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
.vortex/installer/tests/Fixtures/install/_baseline/renovate.json(1 hunks)renovate.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (12)
- GitHub Check: build (0)
- GitHub Check: build (1)
- GitHub Check: vortex-test-workflow (2)
- GitHub Check: vortex-test-deployment (0)
- GitHub Check: vortex-test-deployment (1)
- GitHub Check: vortex-test-workflow (0)
- GitHub Check: vortex-test-workflow (1)
- GitHub Check: vortex-test-common
- GitHub Check: vortex-test-installer (8.4)
- GitHub Check: vortex-test-installer (8.3)
- GitHub Check: vortex-test-installer (8.2)
- GitHub Check: vortex-test-docs
🔇 Additional comments (2)
.vortex/installer/tests/Fixtures/install/_baseline/renovate.json (1)
107-108: Correct key replacement and pattern update
The custom regex manager now uses"fileMatch"instead of the deprecated"managerFilePatterns", and the pattern"docker-compose\\.ya?ml$"matches both.ymland.yamlfiles as intended.renovate.json (1)
107-108: Root config: custom regex manager update is correct
Replacing"managerFilePatterns"with"fileMatch"and updating the pattern to"docker-compose\\.ya?ml$"properly captures both Docker Compose filename variants.
.vortex/installer/tests/Fixtures/install/_baseline/renovate.json
Outdated
Show resolved
Hide resolved
renovate.json
Outdated
| "fileMatch": [ | ||
| "docker-compose\\.ya?ml$" |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Optional: Anchor the filename pattern
For stricter matches, you may anchor the regex with ^ and $:
"fileMatch": ["^docker-compose\\.ya?ml$"]🤖 Prompt for AI Agents
In renovate.json at lines 107 to 108, the fileMatch regex for matching
docker-compose YAML files should be anchored with ^ and $ to ensure exact
filename matches. Update the pattern to "^docker-compose\\.ya?ml$" to strictly
match only the intended filenames without partial matches.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1686 +/- ##
========================================
Coverage 71.63% 71.63%
========================================
Files 76 76
Lines 4347 4347
========================================
Hits 3114 3114
Misses 1233 1233 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AlexSkrypnyk
force-pushed
the
feature/fix-renovate-config
branch
from
98e5faa to
b43c252
Compare
AlexSkrypnyk
force-pushed
the
feature/fix-renovate-config
branch
from
b43c252 to
36ba966
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (5)
.circleci/config.yml(1 hunks).github/workflows/deps-updates.yml(1 hunks).github/workflows/vortex-test-common.yml(1 hunks).vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml(1 hunks).vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml
[error] 1-1: syntax error: found character '@' that cannot start any token
(syntax)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: build (1)
- GitHub Check: build (0)
- GitHub Check: vortex-test-deployment (1)
- GitHub Check: vortex-test-workflow (0)
- GitHub Check: vortex-test-workflow (2)
- GitHub Check: vortex-test-workflow (3)
- GitHub Check: vortex-test-workflow (1)
🔇 Additional comments (5)
.github/workflows/deps-updates.yml (1)
18-19: Approve Renovate config validator integration
Thesuzuki-shunsuke/github-action-renovate-config-validator@v1.1.1step is properly inserted and aligns with other workflows to enforce your Renovate configuration schema..circleci/config.yml (1)
413-413:Details
✅ Verification successful
Bump Renovate Docker image to match other workflows
You've updated thedeps-updatesjob image torenovate/renovate:40.36.8, aligning with the GitHub Actions workflows. Please confirm this tag exists and is compatible with your CI setup.Run:
🏁 Script executed:
#!/bin/bash # Verify the Renovate Docker image is available docker pull renovate/renovate:40.36.8Length of output: 136
I’ll verify the tag via the Docker Hub API since
dockerisn’t available in this environment.
🏁 Script executed:
#!/bin/bash # Check HTTP status for the renovate/renovate:40.36.8 tag on Docker Hub curl -s -o /dev/null -w "%{http_code}" https://registry.hub.docker.com/v2/repositories/renovate/renovate/tags/40.36.8Length of output: 123
✅ Renovate Docker image tag verified
- File
.circleci/config.yml, line 413 updated torenovate/renovate:40.36.8- Confirmed tag
40.36.8exists on Docker Hub (HTTP 200)No further action required.
.vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml (1)
5-6: Validate updated default email in fixture workflow
The defaultRENOVATE_GIT_AUTHORhas been updated to userenovatebot@the-new-hope-domain.example, which correctly reflects the intended change and keeps the fixture aligned with the primary workflows..vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml (1)
14-19: Confirm placeholder versions in baseline workflow
You've added theactions/setup-nodeandgithub-action-renovate-config-validatorsteps using__VERSION__placeholders. Ensure these get substituted withv4.4.0andv1.1.1(or updated values) during template rendering so the baseline remains consistent with the root CI workflows..github/workflows/vortex-test-common.yml (1)
75-80: Approve Renovate configuration validation step
The newValidate Renovate configurationstep usingsuzuki-shunsuke/github-action-renovate-config-validator@v1.1.1is correctly placed after linting. It ensures your Renovate config stays in sync with the workflows.
| - uses: actions/setup-node@v4.4.0 | ||
| with: | ||
| node-version: 22.13.1 | ||
|
|
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Ensure consistent Node.js setup across workflows
The addition of actions/setup-node@v4.4.0 with node-version: 22.13.1 looks correct, but please verify that this Node.js version is supported in your other CI workflows to avoid runtime mismatches.
Run:
🏁 Script executed:
#!/bin/bash
# List all Node.js versions pinned in GitHub Actions
rg -n "uses: actions/setup-node@" -A1 .github/workflowsLength of output: 842
🏁 Script executed:
#!/bin/bash
# Show Node.js version configured for each setup-node usage
rg -n "uses: actions/setup-node@" -A2 .github/workflowsLength of output: 1315
Align Node.js versions across workflows
Your deps-updates.yml is pinning Node.js 22.13.1, but in vortex-test-common.yml you’re using 22.16.0—and the docs workflows don’t even specify a version (defaulting silently). To prevent hard-to-debug runtime mismatches, pick one version and apply it everywhere:
• .github/workflows/deps-updates.yml (lines 14–16)
– Change node-version: 22.13.1 → 22.16.0 (to match vortex-test-common)
• .github/workflows/vortex-test-docs.yml & vortex-release-docs.yml
– Add an explicit with: node-version: 22.16.0 under the actions/setup-node@v4 step
🤖 Prompt for AI Agents
In .github/workflows/deps-updates.yml at lines 14 to 17, the Node.js version is
set to 22.13.1, which is inconsistent with other workflows using 22.16.0. Update
the node-version under actions/setup-node@v4.4.0 to 22.16.0 to align with
vortex-test-common.yml. Additionally, in vortex-test-docs.yml and
vortex-release-docs.yml workflows, explicitly add the node-version: 22.16.0
under their actions/setup-node@v4 steps to ensure consistent Node.js versions
across all CI workflows.
36ba966 to
596c051
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
.github/workflows/deps-updates.yml (1)
14-17: Align Node.js versions across workflows
Thenode-version: 22.13.1here differs from22.16.0pinned elsewhere. Consider standardizing on a single Node.js version to avoid environment mismatches.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (5)
.circleci/config.yml(1 hunks).github/workflows/deps-updates.yml(1 hunks).github/workflows/vortex-test-common.yml(2 hunks).vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml(1 hunks).vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml
[error] 1-1: syntax error: found character '@' that cannot start any token
(syntax)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: build (1)
- GitHub Check: build (0)
- GitHub Check: vortex-test-workflow (3)
- GitHub Check: vortex-test-workflow (0)
- GitHub Check: vortex-test-workflow (2)
- GitHub Check: vortex-test-workflow (1)
🔇 Additional comments (5)
.circleci/config.yml (1)
413-413: Updated Renovate Docker image version
The Docker image for thedeps-updatesjob was bumped torenovate/renovate:40.36.8to align with other CI workflows..vortex/installer/tests/Fixtures/install/names/.github/workflows/deps-updates.yml (1)
5-6: Default Renovate Git author updated
The fallbackRENOVATE_GIT_AUTHORwas updated to userenovatebot@the-new-hope-domain.example, reflecting the new domain in your fixtures..github/workflows/vortex-test-common.yml (1)
80-82: Add Renovate configuration validation
Introducingsuzuki-shunsuke/github-action-renovate-config-validator@v1.1.1here validates your Renovate config prior to execution, improving consistency and catching misconfigurations early..vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml (1)
14-19: Insert Node.js setup and Renovate config validator
Adding theactions/setup-node@__VERSION__step withnode-version: 22.13.1and the Renovate config validation action brings this baseline workflow in line with your other Renovate CI setups..github/workflows/deps-updates.yml (1)
18-19: Add Renovate configuration validation
Usingsuzuki-shunsuke/github-action-renovate-config-validator@v1.1.1immediately after setup-node ensures your Renovate configuration is validated before executing the bot.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/deps-updates.yml(1 hunks).github/workflows/vortex-release-docs.yml(1 hunks).github/workflows/vortex-test-common.yml(2 hunks).github/workflows/vortex-test-docs.yml(1 hunks).vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: build (1)
- GitHub Check: build (0)
- GitHub Check: vortex-test-workflow (3)
- GitHub Check: vortex-test-workflow (2)
- GitHub Check: vortex-test-deployment (1)
- GitHub Check: vortex-test-workflow (0)
- GitHub Check: vortex-test-workflow (1)
🔇 Additional comments (5)
.github/workflows/vortex-release-docs.yml (1)
89-90: Pin Node.js version to 22.16.0 for consistency across workflows
Explicitly specifyingnode-version: 22.16.0here aligns with the other CI workflows and prevents unexpected changes when the default Node.js version updates..github/workflows/vortex-test-docs.yml (1)
23-24: Explicitly set Node.js version to 22.16.0
Addingnode-version: 22.16.0ensures a consistent runtime across all docs-testing jobs..github/workflows/vortex-test-common.yml (2)
64-66: Standardize Node.js setup to version 22.16.0
Pinning the Node.js version here harmonizes the environment with other workflows.
77-82: Add Renovate configuration validation step
Introducingsuzuki-shunsuke/github-action-renovate-config-validator@v1.1.1ensures that Renovate’s config stays in sync with the Renovate workflow version..vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/deps-updates.yml (1)
14-19: Insert Node.js setup and Renovate config validator
The baseline fixture now mirrors the main workflow by setting up Node.js (22.16.0) before running the Renovate config validator, ensuring fixture accuracy.
| - uses: actions/setup-node@v4.4.0 | ||
| with: | ||
| node-version: 22.13.1 | ||
| node-version: 22.16.0 | ||
|
|
||
| - uses: suzuki-shunsuke/github-action-renovate-config-validator@v1.1.1 | ||
|
|
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Setup Node.js (22.16.0) and validate Renovate config
Adding actions/setup-node@v4.4.0 with node-version: 22.16.0 and the github-action-renovate-config-validator step aligns this workflow with others.
You may consider using the unpinned major reference (actions/setup-node@v4) instead of v4.4.0 to automatically pick up patch releases across all workflows.
🤖 Prompt for AI Agents
In .github/workflows/deps-updates.yml around lines 14 to 19, the setup-node
action is pinned to version v4.4.0. To keep the workflow updated with the latest
patch releases automatically, change the action reference from
'actions/setup-node@v4.4.0' to 'actions/setup-node@v4' so it uses the unpinned
major version.
Summary by CodeRabbit