[#1671] Fixed domain replacements.

[AlexSkrypnyk]

#1671

Summary by CodeRabbit

• Refactor
  • Adjusted the order of elements in internal processing to improve consistency. No visible changes to end-user functionality.

[coderabbitai]

Walkthrough

The update reorders the placement of the Domain::id() element within the $ids array in the process() method of the PromptManager class. No other logic, error handling, or control flow is affected by this change.

Changes

File(s)	Change Summary
.vortex/installer/src/Prompts/PromptManager.php	Moved Domain::id() position within the $ids array in process() method

Poem

A hop and a skip, I shuffle the line,
Domain hops up, now it’s just fine.
Arrays in order, neat as can be,
PromptManager’s list is rabbit-approved, you see!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 67f280e and d6e67a1.

⛔ Files ignored due to path filters (16)

• .vortex/installer/tests/Fixtures/install/_baseline/.env is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/_baseline/README.md is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/db_download_source_acquia/.env is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/db_download_source_container_registry/.env is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/db_download_source_ftp/.env is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/db_download_source_lagoon/.env is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/hosting_acquia/.env is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/hosting_acquia/hooks/library/domains.txt is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/hosting_lagoon/.env is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/hosting_lagoon/.lagoon.yml is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/names/.env is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/names/README.md is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/preserve_docs_onboarding_disabled/README.md is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/provision_database_lagoon/.env is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/provision_database_lagoon/.lagoon.yml is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/provision_profile/.env is excluded by !.vortex/installer/tests/Fixtures/**

📒 Files selected for processing (1)

• .vortex/installer/src/Prompts/PromptManager.php (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

.vortex/installer/src/Prompts/PromptManager.php (2)

.vortex/installer/src/Prompts/Handlers/Domain.php (1)

• Domain (11-35)

.vortex/installer/src/Prompts/Handlers/AbstractHandler.php (1)

• id (76-86)

⏰ Context from checks skipped due to timeout of 90000ms (12)

• GitHub Check: build (0)
• GitHub Check: build (1)
• GitHub Check: vortex-test-deployment (1)
• GitHub Check: vortex-test-workflow (2)
• GitHub Check: vortex-test-deployment (0)
• GitHub Check: vortex-test-workflow (0)
• GitHub Check: vortex-test-workflow (3)
• GitHub Check: vortex-test-workflow (1)
• GitHub Check: vortex-test-common
• GitHub Check: vortex-test-installer (8.4)
• GitHub Check: vortex-test-installer (8.2)
• GitHub Check: vortex-test-installer (8.3)

🔇 Additional comments (1)

.vortex/installer/src/Prompts/PromptManager.php (1)

493-502: Reevaluate Domain handler ordering to ensure comprehensive file replacement

The Domain::process() call was moved to run immediately after ModulePrefix::id() (line 498), before handlers like MachineName, Name, and other generators. Since Domain::process() replaces placeholder domains in files, executing it too early may miss replacements in files produced by downstream handlers.
Please confirm that this new position still covers all generated files. If not, consider relocating Domain::id() to the end of the sequence—after all file-creation handlers—or implementing a secondary pass to catch late additions.

Likely an incorrect or invalid review comment.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.75%. Comparing base (67f280e) to head (d6e67a1).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1712      +/-   ##
===========================================
+ Coverage    66.51%   71.75%   +5.24%     
===========================================
  Files           76       76              
  Lines         4366     4366              
===========================================
+ Hits          2904     3133     +229     
+ Misses        1462     1233     -229     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.