Fixed false negatives assertions in settings test for testEnvironmentOverrides().

[AlexSkrypnyk]

Summary by CodeRabbit

• Tests
  • Improved flexibility in test environment setup by allowing custom configuration and file path values in environment-related tests.
  • Enhanced test methods to support conditional assignment of environment variables, enabling easier overrides during testing.

[coderabbitai]

Walkthrough

The updates modify how test environment settings and environment variables are assigned in two PHPUnit test files. Assignments for configuration paths and file paths are now set using explicit string values and allow for conditional overrides via input arrays, rather than relying solely on static constants. No public interfaces were changed.

Changes

File(s)	Change Summary
tests/phpunit/Drupal/EnvironmentSettingsTest.php	Reordered and updated assignments in testEnvironmentOverrides(); switched from static constants to string values for config and file paths.
tests/phpunit/Drupal/SettingsTestCase.php	Changed environment variable assignments in setEnvVars() to use input array overrides with null coalescing, instead of always using constants.

Poem

In testy warrens, settings shift anew,
Paths once set in stone now flex for you.
With strings and overrides, the code hops free,
A rabbit’s delight in such flexibility!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae445b7 and 5dd075a.

⛔ Files ignored due to path filters (9)

• .vortex/installer/tests/Fixtures/install/_baseline/tests/phpunit/Drupal/EnvironmentSettingsTest.php is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/_baseline/tests/phpunit/Drupal/SettingsTestCase.php is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/ciprovider_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.php is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/deploy_type_all_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.php is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/deploy_type_none_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.php is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/deps_updates_provider_ci_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.php is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/hosting_acquia/tests/phpunit/Drupal/EnvironmentSettingsTest.php is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/hosting_lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.php is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/provision_database_lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.php is excluded by !.vortex/installer/tests/Fixtures/**

📒 Files selected for processing (2)

• tests/phpunit/Drupal/EnvironmentSettingsTest.php (1 hunks)
• tests/phpunit/Drupal/SettingsTestCase.php (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (13)

• GitHub Check: build (0)
• GitHub Check: build (1)
• GitHub Check: vortex-test-workflow (3)
• GitHub Check: vortex-test-deployment (0)
• GitHub Check: vortex-test-deployment (1)
• GitHub Check: vortex-test-common
• GitHub Check: vortex-test-workflow (1)
• GitHub Check: vortex-test-workflow (2)
• GitHub Check: vortex-test-workflow (0)
• GitHub Check: vortex-test-installer (8.3)
• GitHub Check: vortex-test-installer (8.4)
• GitHub Check: vortex-test-installer (8.2)
• GitHub Check: vortex-test-docs

🔇 Additional comments (2)

tests/phpunit/Drupal/SettingsTestCase.php (1)

162-165: Excellent enhancement for test flexibility!

The use of the null coalescing operator allows environment variables to be overridden during tests while maintaining backward compatibility with existing test constants. This change enables more comprehensive testing scenarios where custom paths need to be validated.

tests/phpunit/Drupal/EnvironmentSettingsTest.php (1)

382-385: Correctly aligns test expectations with environment variable overrides.

The reordering of settings assignments and the change to expect 'custom_config' (instead of the static constant) properly reflects the new behavior where environment variables override the default testing constants. This fixes the false negative assertions mentioned in the PR title.

The test now correctly validates that when DRUPAL_CONFIG_PATH is set to 'custom_config' (line 346), the resulting config_sync_directory setting matches that value.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.89%. Comparing base (ae445b7) to head (5dd075a).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1737   +/-   ##
========================================
  Coverage    71.89%   71.89%           
========================================
  Files           77       77           
  Lines         4415     4415           
========================================
  Hits          3174     3174           
  Misses        1241     1241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.