[#1665] Added missing VORTEX_DB_DOWNLOAD_SSH_FILE to .env.local.example.
#1824
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Ahoy
participant Composer
Developer->>Ahoy: Run update-fixtures
Ahoy->>Composer: test -- --filter=testInstall@baseline
alt Test fails
Ahoy->>Composer: Retry test -- --filter=testInstall@baseline
end
Ahoy->>Composer: test -- --filter=testInstall
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Note ⚡️ Unit Test Generation - BetaCodeRabbit's unit test generation is now available in Beta! Automatically generate comprehensive unit tests for your code changes, ensuring better test coverage and catching edge cases you might miss. Our AI analyzes your code structure and creates tests that follow best practices and your project's testing patterns. Learn more here, or just try it under ✨ Finishing Touches. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (20)
.vortex/installer/tests/Fixtures/install/_baseline/.env.localis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/_baseline/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/db_download_source_acquia/.env.localis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/db_download_source_acquia/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/db_download_source_container_registry/.env.localis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/db_download_source_container_registry/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/db_download_source_ftp/.env.localis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/db_download_source_ftp/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/db_download_source_lagoon/.env.localis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/db_download_source_lagoon/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/hosting_acquia/.env.localis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/hosting_acquia/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/hosting_lagoon/.env.localis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/hosting_lagoon/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/names/.env.localis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/names/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/provision_database_lagoon/.env.localis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/provision_database_lagoon/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/provision_profile/.env.localis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/provision_profile/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (2)
.env.local.example(3 hunks).vortex/.ahoy.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: AlexSkrypnyk
PR: drevops/vortex#0
File: :0-0
Timestamp: 2025-05-29T12:15:32.188Z
Learning: Do not review files in `.vortex/installer/tests/Fixtures/install` directory as they are test fixtures.
.vortex/.ahoy.yml (3)
Learnt from: AlexSkrypnyk
PR: drevops/vortex#0
File: :0-0
Timestamp: 2025-05-29T12:15:32.188Z
Learning: Do not review files in .vortex/installer/tests/Fixtures/install directory as they are test fixtures.
Learnt from: AlexSkrypnyk
PR: #1697
File: .vortex/installer/tests/Fixtures/install/provision_database_lagoon/docs/onboarding.md:16-17
Timestamp: 2025-06-02T00:41:36.321Z
Learning: DO NOT EVER REVIEW FILES IN .vortex/installer/tests/Fixtures/ directory - these are test fixtures and should not be reviewed under any circumstances.
Learnt from: CR
PR: drevops/vortex#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T15:00:28.327Z
Learning: Composer dependencies are updated automatically with compatibility checks via RenovateBot
.env.local.example (1)
Learnt from: AlexSkrypnyk
PR: #1816
File: .docker/cli.dockerfile:72-76
Timestamp: 2025-07-23T01:16:30.963Z
Learning: In the Vortex project, unauthenticated Composer installs should be allowed, so GitHub token secrets should not be marked as required=true in Docker build mounts. The conditional check if [ -s /run/secrets/github_token ] is the preferred approach to allow builds to proceed without a token when needed.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: build (0)
- GitHub Check: build (1)
- GitHub Check: vortex-test-deployment (0)
- GitHub Check: vortex-test-deployment (1)
- GitHub Check: vortex-test-workflow (3)
- GitHub Check: vortex-test-workflow (2)
- GitHub Check: vortex-test-workflow (0)
- GitHub Check: vortex-test-workflow (1)
- GitHub Check: vortex-test-common
- GitHub Check: vortex-test-installer (8.4)
- GitHub Check: vortex-test-installer (8.2)
- GitHub Check: vortex-test-installer (8.3)
🔇 Additional comments (1)
.env.local.example (1)
11-17: New helper vars look good.Placing
VORTEX_LOCALDEV_URLandVORTEX_DEBUGat the top improves discoverability without altering defaults.
| # SSH file used to download the database dump from Lagoon. Defaults to "${HOME}/.ssh/id_rsa}". | ||
| # VORTEX_DB_DOWNLOAD_SSH_FILE= |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Trim the stray brace in the default SSH-key path.
The sentence ends with "...${HOME}/.ssh/id_rsa}" – the closing } after the filename is unmatched and will confuse copy-pasting.
-# SSH file used to download the database dump from Lagoon. Defaults to "${HOME}/.ssh/id_rsa}".
+# SSH file used to download the database dump from Lagoon. Defaults to "${HOME}/.ssh/id_rsa".📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # SSH file used to download the database dump from Lagoon. Defaults to "${HOME}/.ssh/id_rsa}". | |
| # VORTEX_DB_DOWNLOAD_SSH_FILE= | |
| # SSH file used to download the database dump from Lagoon. Defaults to "${HOME}/.ssh/id_rsa". | |
| # VORTEX_DB_DOWNLOAD_SSH_FILE= |
🤖 Prompt for AI Agents
In .env.local.example around lines 59 to 60, remove the stray closing brace '}'
at the end of the default SSH key path string "${HOME}/.ssh/id_rsa}". It should
be corrected to "${HOME}/.ssh/id_rsa" without the trailing brace to avoid
confusion and errors when copying the path.
| composer --working-dir=installer test -- --filter=testInstall@baseline || composer --working-dir=installer test -- --filter=testInstall@baseline | ||
| composer --working-dir=installer test -- --filter=testInstall || composer --working-dir=installer test -- --filter=testInstall |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Avoid copy-pasted retries for maintainability.
You now have two nearly identical composer invocations separated by || for a retry. Consider DRY-ing this into a tiny helper or using --retry/until so that only the filter value changes between lines.
- composer --working-dir=installer test -- --filter=testInstall@baseline || composer --working-dir=installer test -- --filter=testInstall@baseline
+ until composer --working-dir=installer test -- --filter=testInstall@baseline; do :; doneKeeps the intent while removing duplication.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| composer --working-dir=installer test -- --filter=testInstall@baseline || composer --working-dir=installer test -- --filter=testInstall@baseline | |
| composer --working-dir=installer test -- --filter=testInstall || composer --working-dir=installer test -- --filter=testInstall | |
| until composer --working-dir=installer test -- --filter=testInstall@baseline; do :; done | |
| composer --working-dir=installer test -- --filter=testInstall || composer --working-dir=installer test -- --filter=testInstall |
🤖 Prompt for AI Agents
In .vortex/.ahoy.yml around lines 93 to 94, the composer commands are duplicated
with a retry using `||`. Refactor this by creating a small helper or using a
retry mechanism like `--retry` or `until` to avoid repeating the entire command.
This means extracting the common composer invocation and only varying the filter
argument, thereby reducing duplication and improving maintainability.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1824 +/- ##
========================================
Coverage 74.52% 74.52%
========================================
Files 84 84
Lines 4761 4761
Branches 35 35
========================================
Hits 3548 3548
Misses 1213 1213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AlexSkrypnyk
deleted the
feature/1665-missing-VORTEX_DB_DOWNLOAD_SSH_FILE
branch
Closes #1665
Summary by CodeRabbit
Documentation
Chores