-
-
Notifications
You must be signed in to change notification settings - Fork 28
Removed generic private package used for testing from the root composer.json.
#1835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change updates a test method and its documentation in a workflow test to focus on "Package token" instead of "GitHub token" handling. Additionally, the composer configuration removes a private package dependency and its corresponding repository entry. No other logic or configuration is altered. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 phpcs (3.7.2).vortex/tests/phpunit/Functional/WorkflowTest.phpERROR: Referenced sniff "Drupal" does not exist Run "phpcs --help" for usage information 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings.vortex/tests/phpunit/Functional/WorkflowTest.php (1)Learnt from: AlexSkrypnyk ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
🔇 Additional comments (1)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
0bc8d68 to
6239425
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1835 +/- ##
===========================================
- Coverage 74.02% 74.00% -0.03%
===========================================
Files 84 84
Lines 4813 4813
Branches 35 35
===========================================
- Hits 3563 3562 -1
- Misses 1250 1251 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit