Fixed GHA deployment not triggering for tags. #2039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughAdds tag triggers to the GitHub Actions workflow, expands branch patterns, and sets a VORTEX_DEPLOY_MODE env var in the Deploy job to distinguish tag vs. branch deployments based on ref. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub
participant WF as build-test-deploy.yml
participant Deploy as Deploy Job
Dev->>GH: Push commit or create tag
GH->>WF: Trigger workflow (push on branches/tags)
alt Tag ref (refs/tags/...)
WF->>Deploy: Start with env VORTEX_DEPLOY_MODE=tag
else Branch ref
WF->>Deploy: Start with env VORTEX_DEPLOY_MODE=branch
end
Deploy->>Deploy: Execute deployment steps using mode
Deploy-->>GH: Job status
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro ⛔ Files ignored due to path filters (17)
📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1).github/workflows/**📄 CodeRabbit inference engine (CLAUDE.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
🔇 Additional comments (2)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2039 +/- ##
========================================
Coverage 63.95% 63.95%
========================================
Files 91 91
Lines 5637 5637
Branches 44 44
========================================
Hits 3605 3605
Misses 2032 2032 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2023
Summary by CodeRabbit