Skip to content

Conversation

@AlexSkrypnyk
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk commented Nov 11, 2025

Closes #1482

  • Replaced individual VORTEX_DEPLOY_SKIP_PR_<NUMBER> and VORTEX_DEPLOY_SKIP_BRANCH_<SAFE_BRANCH> variables with comma-separated list variables
  • Added VORTEX_DEPLOY_SKIP_PRS for PR numbers (single or comma-separated)
  • Added VORTEX_DEPLOY_SKIP_BRANCHES for branch names (single or comma-separated)
  • Updated scripts/vortex/deploy.sh with new list-based skip logic
  • Updated PHPUnit tests to cover new skip scenarios
  • Updated documentation for deployment workflows and variables
  • Updated GitHub Actions workflow to include new environment variables
  • Updated CI variables configuration
  • Updated installer baseline fixtures

Migration

This is a breaking change. Projects using the old mechanism will need to migrate from:

VORTEX_DEPLOY_SKIP_PR_123: "1" 
VORTEX_DEPLOY_SKIP_BRANCH_FEATURE_TEST: "1"

To:

VORTEX_DEPLOY_ALLOW_SKIP: "1" 
VORTEX_DEPLOY_SKIP_PRS: "123" 
VORTEX_DEPLOY_SKIP_BRANCHES: "feature/test"

@coderabbitai
Copy link

coderabbitai bot commented Nov 11, 2025

Warning

Rate limit exceeded

@AlexSkrypnyk has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 12 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between dafe633 and 55ee9c2.

⛔ Files ignored due to path filters (2)
  • .vortex/installer/tests/Fixtures/install/_baseline/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/install/deploy_types_none_gha/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (7)
  • .github/workflows/build-test-deploy.yml (1 hunks)
  • .vortex/docs/.utils/variables/extra/ci.variables.sh (1 hunks)
  • .vortex/docs/content/workflows/deployment.mdx (1 hunks)
  • .vortex/docs/content/workflows/variables.mdx (2 hunks)
  • .vortex/tests/bats/unit/deploy.bats (1 hunks)
  • .vortex/tests/phpunit/Functional/DeploymentTest.php (3 hunks)
  • scripts/vortex/deploy.sh (1 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/1428-update-deployment-bypass

Comment @coderabbitai help to get the list of available commands and usage tips.

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/1428-update-deployment-bypass branch from 817edd7 to a249134 Compare November 11, 2025 22:46
@github-actions github-actions bot temporarily deployed to commit November 11, 2025 22:49 Inactive
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.92%. Comparing base (dafe633) to head (55ee9c2).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2088      +/-   ##
===========================================
+ Coverage    67.46%   67.92%   +0.45%     
===========================================
  Files           94       94              
  Lines         4617     4614       -3     
  Branches        44       44              
===========================================
+ Hits          3115     3134      +19     
+ Misses        1502     1480      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/1428-update-deployment-bypass branch from a249134 to 33fdfc5 Compare November 11, 2025 23:13
@github-actions github-actions bot temporarily deployed to commit November 11, 2025 23:15 Inactive
- Replaced individual `VORTEX_DEPLOY_SKIP_PR_<NUMBER>` and `VORTEX_DEPLOY_SKIP_BRANCH_<SAFE_BRANCH>` variables with comma-separated list variables
- Added `VORTEX_DEPLOY_SKIP_PRS` for PR numbers (single or comma-separated)
- Added `VORTEX_DEPLOY_SKIP_BRANCHES` for branch names (single or comma-separated)
- Updated `scripts/vortex/deploy.sh` with new list-based skip logic
- Updated PHPUnit tests to cover new skip scenarios
- Updated documentation for deployment workflows and variables
- Updated GitHub Actions workflow to include new environment variables
- Updated CI variables configuration
- Updated installer baseline fixtures

  This is a breaking change. Projects using the old mechanism will need to migrate from:
  VORTEX_DEPLOY_SKIP_PR_123: "1"
  VORTEX_DEPLOY_SKIP_BRANCH_FEATURE_TEST: "1"

  To:
  VORTEX_DEPLOY_ALLOW_SKIP: "1"
  VORTEX_DEPLOY_SKIP_PRS: "123"
  VORTEX_DEPLOY_SKIP_BRANCHES: "feature/test"
@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/1428-update-deployment-bypass branch from 33fdfc5 to 55ee9c2 Compare November 11, 2025 23:45
@github-actions github-actions bot temporarily deployed to commit November 11, 2025 23:48 Inactive
@AlexSkrypnyk AlexSkrypnyk merged commit c178365 into develop Nov 12, 2025
28 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/1428-update-deployment-bypass branch November 12, 2025 00:14
@github-project-automation github-project-automation bot moved this from BACKLOG to Release queue in Vortex Nov 12, 2025
@AlexSkrypnyk AlexSkrypnyk added this to the 25.11.0 milestone Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Released in 1.34.0

Development

Successfully merging this pull request may close these issues.

Update deployment bypass mechanism to use named variables

2 participants