Skip to content

Updated Renovate configuration to name all groups consistently and exclude language version updates.#2321

Merged
AlexSkrypnyk merged 1 commit intomainfrom
feature/fix-renovate-language-versions
Feb 24, 2026
Merged

Updated Renovate configuration to name all groups consistently and exclude language version updates.#2321
AlexSkrypnyk merged 1 commit intomainfrom
feature/fix-renovate-language-versions

Conversation

@AlexSkrypnyk
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk commented Feb 24, 2026

Summary by CodeRabbit

  • Documentation

    • Clarified fixture regeneration workflow and snapshot update procedures for developers.
  • Chores

    • Reorganized dependency management configuration with improved group organization and naming for PHP, JavaScript, Docker, and GitHub Actions packages.

@coderabbitai
Copy link

coderabbitai bot commented Feb 24, 2026

Walkthrough

Documentation expanded in the installer guide clarifying fixture regeneration procedures, explaining that all fixture files are regenerated from root template files via ahoy update-snapshots. Additionally, Renovate configuration restructured with explicit group naming and updated match rules across PHP, JavaScript, Docker, and GitHub Actions groups.

Changes

Cohort / File(s) Summary
Installer Documentation
.vortex/installer/CLAUDE.md
Expanded the "Updating Fixtures" CRITICAL note from a single sentence to a multi-line explanation clarifying fixture regeneration from root templates via ahoy update-snapshots and emphasizing that only root template files should be modified.
Renovate Configuration
renovate.json
Restructured Renovate groups with clearer naming conventions; introduced separate blocks for PHP and JavaScript language versions; renamed existing groups to include language and scope prefixes; updated match rules from matchFileNames to matchManagers in language version groups; expanded scope descriptors for Docker and GitHub Actions groups; maintained enabled/disabled semantics.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

Poem

🐰 Fixtures fresh from template roots,
Groups renamed with clearer shoots,
Renovate speaks with names so clear,
PHP, JavaScript—all structured here,
Configuration hops along! 🎯

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately summarizes the main changes: renaming Renovate groups for consistency and excluding language version updates, which aligns with the renovate.json modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/fix-renovate-language-versions

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
renovate.json (1)

113-125: ⚠️ Potential issue | 🟡 Minor

Address lock file matching in negation-only pattern.

Renovate's matchFileNames supports negation-only patterns, but evaluates them against both package files and lock files (e.g., package-lock.json). This means ["!package.json"] will still match lock files, defeating the intent to exclude root npm updates.

Renovate's documentation recommends avoiding negative globs in matchFileNames for this reason. Exclude both files explicitly instead: ["!package.json", "!package-lock.json"], or consider using ignorePaths if you want to skip paths entirely.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@renovate.json` around lines 113 - 125, The negation-only glob in the
renovate.json group (groupSlug "js-non-root", matchFileNames ["!package.json"])
still matches lockfiles like package-lock.json; update the group to explicitly
exclude lock files as well (e.g., change matchFileNames to include
"!package-lock.json" alongside "!package.json") or switch to using ignorePaths
for the same effect so root npm lockfiles are not matched.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@renovate.json`:
- Around line 113-125: The negation-only glob in the renovate.json group
(groupSlug "js-non-root", matchFileNames ["!package.json"]) still matches
lockfiles like package-lock.json; update the group to explicitly exclude lock
files as well (e.g., change matchFileNames to include "!package-lock.json"
alongside "!package.json") or switch to using ignorePaths for the same effect so
root npm lockfiles are not matched.

ℹ️ Review info

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e168931 and d785ac8.

⛔ Files ignored due to path filters (1)
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/renovate.json is excluded by !.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (2)
  • .vortex/installer/CLAUDE.md
  • renovate.json

@github-actions
Copy link

Code Coverage Report:
  2026-02-24 02:44:53

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.65% (177/187)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-02-24 02:44:54

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.65% (177/187)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-02-24 02:48:13

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.65% (177/187)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-02-24 02:48:26

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.65% (177/187)

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.09%. Comparing base (487986a) to head (d785ac8).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2321      +/-   ##
==========================================
- Coverage   78.62%   78.09%   -0.53%     
==========================================
  Files         124      117       -7     
  Lines        6404     6245     -159     
  Branches       44        0      -44     
==========================================
- Hits         5035     4877     -158     
+ Misses       1369     1368       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexSkrypnyk AlexSkrypnyk merged commit daea0fb into main Feb 24, 2026
34 of 35 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/fix-renovate-language-versions branch February 24, 2026 05:52
@github-project-automation github-project-automation bot moved this from BACKLOG to Release queue in Vortex Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Release queue

Development

Successfully merging this pull request may close these issues.

1 participant