Updated Renovate configuration to name all groups consistently and exclude language version updates.#2321
Conversation
…clude language version updates.
WalkthroughDocumentation expanded in the installer guide clarifying fixture regeneration procedures, explaining that all fixture files are regenerated from root template files via ahoy update-snapshots. Additionally, Renovate configuration restructured with explicit group naming and updated match rules across PHP, JavaScript, Docker, and GitHub Actions groups. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
renovate.json (1)
113-125:⚠️ Potential issue | 🟡 MinorAddress lock file matching in negation-only pattern.
Renovate's
matchFileNamessupports negation-only patterns, but evaluates them against both package files and lock files (e.g.,package-lock.json). This means["!package.json"]will still match lock files, defeating the intent to exclude root npm updates.Renovate's documentation recommends avoiding negative globs in
matchFileNamesfor this reason. Exclude both files explicitly instead:["!package.json", "!package-lock.json"], or consider usingignorePathsif you want to skip paths entirely.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@renovate.json` around lines 113 - 125, The negation-only glob in the renovate.json group (groupSlug "js-non-root", matchFileNames ["!package.json"]) still matches lockfiles like package-lock.json; update the group to explicitly exclude lock files as well (e.g., change matchFileNames to include "!package-lock.json" alongside "!package.json") or switch to using ignorePaths for the same effect so root npm lockfiles are not matched.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@renovate.json`:
- Around line 113-125: The negation-only glob in the renovate.json group
(groupSlug "js-non-root", matchFileNames ["!package.json"]) still matches
lockfiles like package-lock.json; update the group to explicitly exclude lock
files as well (e.g., change matchFileNames to include "!package-lock.json"
alongside "!package.json") or switch to using ignorePaths for the same effect so
root npm lockfiles are not matched.
ℹ️ Review info
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
.vortex/installer/tests/Fixtures/handler_process/_baseline/renovate.jsonis excluded by!.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (2)
.vortex/installer/CLAUDE.mdrenovate.json
|
|
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2321 +/- ##
==========================================
- Coverage 78.62% 78.09% -0.53%
==========================================
Files 124 117 -7
Lines 6404 6245 -159
Branches 44 0 -44
==========================================
- Hits 5035 4877 -158
+ Misses 1369 1368 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
Documentation
Chores