Skip to content

Fixed migration Drupal variables not starting with DRUPAL_.#2357

Merged
AlexSkrypnyk merged 1 commit intomainfrom
feature/fix-migration-variables
Mar 12, 2026
Merged

Fixed migration Drupal variables not starting with DRUPAL_.#2357
AlexSkrypnyk merged 1 commit intomainfrom
feature/fix-migration-variables

Conversation

@AlexSkrypnyk
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk commented Mar 12, 2026

Summary by CodeRabbit

  • Chores

    • Renamed migration-related environment variables from MIGRATION_* to DRUPAL_MIGRATION_* format across configuration and scripts for improved consistency. Users must update their environment variable references to use the new DRUPAL_MIGRATION_* naming convention.
  • Documentation

    • Updated documentation to reflect all migration environment variable name changes.

@coderabbitai
Copy link

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 85372f4d-a4f6-40d6-907f-53978e379123

📥 Commits

Reviewing files that changed from the base of the PR and between 4e3263a and b41f461.

⛔ Files ignored due to path filters (8)
  • .vortex/installer/tests/Fixtures/handler_process/migration_download_source_acquia/scripts/custom/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_download_source_ftp/scripts/custom/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_download_source_lagoon/scripts/custom/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_download_source_s3/scripts/custom/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_download_source_url/scripts/custom/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_enabled/scripts/custom/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/scripts/custom/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/scripts/custom/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (7)
  • .circleci/vortex-test-common.yml
  • .vortex/docs/content/development/variables.mdx
  • .vortex/docs/content/drupal/migrations.mdx
  • .vortex/tests/bats/unit/provision-migration.bats
  • .vortex/tests/generate-vortex-dev-circleci
  • .vortex/tests/phpunit/Traits/Subtests/SubtestAhoyTrait.php
  • scripts/custom/provision-20-migration.sh

Walkthrough

This pull request renames migration-related environment variables from MIGRATION_* to DRUPAL_MIGRATION_* across CircleCI configuration, documentation, test files, and provisioning scripts. Seven variables are systematically renamed to add a DRUPAL_ prefix for consistency.

Changes

Cohort / File(s) Summary
CircleCI Configuration
.circleci/vortex-test-common.yml, .vortex/tests/generate-vortex-dev-circleci
Renamed MIGRATION_SKIP to DRUPAL_MIGRATION_SKIP in job environment variable declarations across DIDI build variants.
Documentation
.vortex/docs/content/development/variables.mdx, .vortex/docs/content/drupal/migrations.mdx
Renamed seven migration variables in documentation from MIGRATION_* to DRUPAL_MIGRATION_* (SKIP, ROLLBACK_SKIP, IMPORT_LIMIT, UPDATE, FEEDBACK, SOURCE_DB_IMPORT, SOURCE_DB_PROBE_TABLE) and updated all prose references.
Tests
.vortex/tests/bats/unit/provision-migration.bats, .vortex/tests/phpunit/Traits/Subtests/SubtestAhoyTrait.php
Updated test assertions, export statements, and log message references to use renamed DRUPAL_MIGRATION_* environment variables.
Provisioning Script
scripts/custom/provision-20-migration.sh
Renamed all seven migration-related variables throughout the script, updated control flow branches (skip checks, import decisions, rollback behavior) and log outputs to reference the new DRUPAL_MIGRATION_* names.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • PR #1677: Modifies provisioning scripts to update helper functions (info/task/note) used in provision scripts.

Suggested labels

PR: Needs review

Poem

🐰 A rabbit's tale of names set right,
Variables dressed in prefixed light,
DRUPAL_ now leads the migration way,
Consistent names for a brighter day!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 37.50% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: renaming migration environment variables to have the DRUPAL_ prefix for consistency.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/fix-migration-variables

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Code Coverage Report:
  2026-03-12 01:59:14

 Summary:
  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)

Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-03-12 02:00:18

 Summary:
  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)

Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-03-12 02:02:59

 Summary:
  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)

Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-03-12 02:03:17

 Summary:
  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)

Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.69%. Comparing base (4e3263a) to head (b41f461).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2357      +/-   ##
==========================================
- Coverage   79.19%   78.69%   -0.50%     
==========================================
  Files         125      118       -7     
  Lines        6589     6430     -159     
  Branches       44        0      -44     
==========================================
- Hits         5218     5060     -158     
+ Misses       1371     1370       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexSkrypnyk AlexSkrypnyk merged commit 03cb665 into main Mar 12, 2026
35 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/fix-migration-variables branch March 12, 2026 02:14
@github-project-automation github-project-automation bot moved this from BACKLOG to Release queue in Vortex Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Released in 1.37.0

Development

Successfully merging this pull request may close these issues.

1 participant