Skip to content

Removed stale references to asset-packagist's installer types.#2359

Merged
AlexSkrypnyk merged 1 commit intomainfrom
feature/fix-installer-path-composerjson
Mar 12, 2026
Merged

Removed stale references to asset-packagist's installer types.#2359
AlexSkrypnyk merged 1 commit intomainfrom
feature/fix-installer-path-composerjson

Conversation

@AlexSkrypnyk
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk commented Mar 12, 2026

Summary by CodeRabbit

  • Documentation

    • Clarified Composer guidance for managing front-end libraries, including placement and type requirements.
    • Added explanatory notes on how specific path entries override defaults and a warning against certain external package sources.
  • Configuration

    • Reduced supported asset installer types to a single library type for simpler Composer configuration.

@coderabbitai
Copy link

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: abad20d9-7582-4599-a703-57557b2302f1

📥 Commits

Reviewing files that changed from the base of the PR and between cde69de and 71d04ed.

⛔ Files ignored due to path filters (5)
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/scripts/custom/provision-10-example.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/hosting_acquia/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/starter_drupal_cms_profile/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (2)
  • .vortex/docs/content/development/composer.mdx
  • composer.json

Walkthrough

Removes Asset Packagist installer types from Composer and updates documentation to require inline Composer packages use type:drupal-library placed under web/libraries/, with an updated installer-paths example and warning against using Asset Packagist.

Changes

Cohort / File(s) Summary
Documentation
.vortex/docs/content/development/composer.mdx
Adds guidance requiring type:drupal-library for inline Composer packages placed in web/libraries/; adds warning against Asset Packagist; updates installer-paths example and explanatory text.
Composer configuration
composer.json
Removes type:bower-asset and type:npm-asset from installer-paths and deletes bower-asset / npm-asset from installer-types, leaving drupal-library as the asset type.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 I nibbled the Bower, hopped past npm's gate,
Inline drupal libraries now lie in state,
In web/libraries/ they gather and play,
A tidy small burrow for assets today,
Hooray for the rabbit who helped clear the way! 🎋

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing outdated asset-packagist installer types from composer configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/fix-installer-path-composerjson

Comment @coderabbitai help to get the list of available commands and usage tips.

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/fix-installer-path-composerjson branch from cde69de to 71d04ed Compare March 12, 2026 02:42
@github-actions
Copy link

Code Coverage Report:
  2026-03-12 02:48:52

 Summary:
  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)

Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-03-12 02:49:10

 Summary:
  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)

Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-03-12 02:52:10

 Summary:
  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)

Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-03-12 02:52:15

 Summary:
  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)

Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.69%. Comparing base (0b68239) to head (71d04ed).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2359      +/-   ##
==========================================
- Coverage   79.19%   78.69%   -0.50%     
==========================================
  Files         125      118       -7     
  Lines        6589     6430     -159     
  Branches       44        0      -44     
==========================================
- Hits         5218     5060     -158     
+ Misses       1371     1370       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexSkrypnyk AlexSkrypnyk merged commit bdb50de into main Mar 12, 2026
45 of 47 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/fix-installer-path-composerjson branch March 12, 2026 03:44
@github-project-automation github-project-automation bot moved this from BACKLOG to Release queue in Vortex Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Released in 1.37.0

Development

Successfully merging this pull request may close these issues.

1 participant