[#2363] Added colour to ahoy confirm.#2366
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.ahoy.yml:
- Line 338: The current echo command keeps ${AHOY_CONFIRM_RESPONSE} in dim text;
update the echo in the confirmation prompt so the dim styling only wraps the
"[y/N]" hint and is reset before printing ${AHOY_CONFIRM_RESPONSE}. Concretely,
adjust the printf/echo format around the existing echo line (the line containing
echo -e and ${AHOY_CONFIRM_RESPONSE}) to place \033[2m...\033[0m around "[y/N]"
only, and ensure a \033[0m reset occurs immediately before
${AHOY_CONFIRM_RESPONSE} so the preset response is printed with normal styling.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 9f47b7a2-b114-4469-bf72-f5d649d0612a
⛔ Files ignored due to path filters (2)
.vortex/installer/tests/Fixtures/handler_process/_baseline/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/scripts/custom/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (1)
.ahoy.yml
| else | ||
| if [ "${AHOY_CONFIRM_WAIT_SKIP}" != "1" ]; then | ||
| echo ">> $1 [y/N] ${AHOY_CONFIRM_RESPONSE}" | ||
| echo -e "\033[31m>> $1\033[0m \033[2m[y/N] ${AHOY_CONFIRM_RESPONSE}\033[0m" |
There was a problem hiding this comment.
Reset dim styling before printing the preset response.
Right now ${AHOY_CONFIRM_RESPONSE} is echoed in dim text too. The linked requirement only dims the [y/N] hint and then shows the provided response.
Suggested fix
- echo -e "\033[31m>> $1\033[0m \033[2m[y/N] ${AHOY_CONFIRM_RESPONSE}\033[0m"
+ echo -e "\033[31m>> $1\033[0m \033[2m[y/N]\033[0m ${AHOY_CONFIRM_RESPONSE}"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| echo -e "\033[31m>> $1\033[0m \033[2m[y/N] ${AHOY_CONFIRM_RESPONSE}\033[0m" | |
| echo -e "\033[31m>> $1\033[0m \033[2m[y/N]\033[0m ${AHOY_CONFIRM_RESPONSE}" |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.ahoy.yml at line 338, The current echo command keeps
${AHOY_CONFIRM_RESPONSE} in dim text; update the echo in the confirmation prompt
so the dim styling only wraps the "[y/N]" hint and is reset before printing
${AHOY_CONFIRM_RESPONSE}. Concretely, adjust the printf/echo format around the
existing echo line (the line containing echo -e and ${AHOY_CONFIRM_RESPONSE}) to
place \033[2m...\033[0m around "[y/N]" only, and ensure a \033[0m reset occurs
immediately before ${AHOY_CONFIRM_RESPONSE} so the preset response is printed
with normal styling.
This comment has been minimized.
This comment has been minimized.
|
|
d6a8ee8 to
3286b52
Compare
|
|
|
|
Closes #2363
Summary by CodeRabbit