[#2362] Use yield in data providers.#2367
Merged
AlexSkrypnyk merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
WalkthroughConverts PHPUnit data providers across tests from returning arrays to yielding Iterators, adds YieldDataProviderRector to Rector config, and updates PHPCS to silence MissingReturnComment false positives for type-hinted returns in test files. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.vortex/installer/tests/Functional/Handlers/ToolsHandlerProcessTest.php (1)
57-494: 🧹 Nitpick | 🔵 TrivialExtract a small dataset builder for the repeated tool/CI permutations.
Most yielded cases duplicate the same
getToolDefinitions()/array_diff()/Env::put()setup and only vary by removed tools, CI provider, and assertion. Pulling that into a helper would make future tool additions much harder to miss in only one branch.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.vortex/installer/tests/Functional/Handlers/ToolsHandlerProcessTest.php around lines 57 - 494, Many test cases repeat the same setup for Tools::getToolDefinitions(), array_diff(), Converter::toList() and Env::put(...) for tools/CI/theme; extract a small reusable builder (e.g., a private static function toolsScenario(array $removedTools, string $ciProvider, ?string $theme = null): array or a helper that returns the two closures used in the yield) that performs the Env::put calls (using Tools::envName(), CiProvider::envName(), Theme::envName()) and returns the appropriate setup closure and assertion closure placeholders; replace each duplicated yield to call this builder with the specific removed tools (like [Tools::PHPCS], [Tools::ESLINT, Tools::STYLELINT], etc.), the CI constants (CiProvider::GITHUB_ACTIONS or CiProvider::CIRCLECI) and optional Theme::OLIVERO so only the differing removed-tools/ci/assertion logic remains in each test case.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.vortex/installer/tests/Functional/Command/InstallCommandTest.php:
- Around line 225-248: Remove the extra blank lines inside the yielded test case
array to match the file's existing formatting style: collapse the blank line
before the 'install_executable_finder_find_callback' closure and the blank line
after its return block so the entries (command_inputs,
install_executable_finder_find_callback, build_runner_exit_callback,
check_requirements_runner_exit_callback, expect_failure, output_assertions) are
contiguous in the yield for the 'Requirements of install command check fails,
missing tar' case; keep the same keys and closures (including
InstallCommand::OPTION_NO_INTERACTION and the TuiOutput assertions) unchanged,
only adjust whitespace.
---
Outside diff comments:
In @.vortex/installer/tests/Functional/Handlers/ToolsHandlerProcessTest.php:
- Around line 57-494: Many test cases repeat the same setup for
Tools::getToolDefinitions(), array_diff(), Converter::toList() and Env::put(...)
for tools/CI/theme; extract a small reusable builder (e.g., a private static
function toolsScenario(array $removedTools, string $ciProvider, ?string $theme =
null): array or a helper that returns the two closures used in the yield) that
performs the Env::put calls (using Tools::envName(), CiProvider::envName(),
Theme::envName()) and returns the appropriate setup closure and assertion
closure placeholders; replace each duplicated yield to call this builder with
the specific removed tools (like [Tools::PHPCS], [Tools::ESLINT,
Tools::STYLELINT], etc.), the CI constants (CiProvider::GITHUB_ACTIONS or
CiProvider::CIRCLECI) and optional Theme::OLIVERO so only the differing
removed-tools/ci/assertion logic remains in each test case.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: aabca1e9-1f56-49ec-bc42-6f021853269e
⛔ Files ignored due to path filters (102)
.vortex/installer/tests/Fixtures/handler_process/_baseline/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/web/modules/custom/sw_base/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/web/modules/custom/sw_base/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/web/themes/custom/star_wars/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/web/themes/custom/star_wars/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/ciprovider_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/ciprovider_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_all_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_all_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_none_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_none_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deps_updates_provider_ci_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deps_updates_provider_ci_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/modules/custom/sw_base/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/modules/custom/sw_base/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/themes/custom/star_wars/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/themes/custom/star_wars/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/modules/custom/sw_base/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/modules/custom/sw_base/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/themes/custom/star_wars/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/themes/custom/star_wars/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_disabled_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_disabled_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_disabled_lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_acquia/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_acquia/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_ftp/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_ftp/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_lagoon/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_s3/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_s3/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_url/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_url/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_config_split/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_config_split/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_environment_indicator/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_environment_indicator/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_robotstxt/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_seckit/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_seckit_shield_stage_file_proxy/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_seckit_shield_stage_file_proxy/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_shield/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_shield/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_stage_file_proxy/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_none/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_none/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/names/web/modules/custom/the_force_base/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/names/web/modules/custom/the_force_base/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/names/web/themes/custom/lightsaber/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/names/web/themes/custom/lightsaber/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/non_interactive_config_file/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/provision_database_lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/services_no_redis/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/services_none/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/theme_claro/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/theme_custom/web/themes/custom/light_saber/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/theme_custom/web/themes/custom/light_saber/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/theme_olivero/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/theme_stark/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/timezone_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/timezone_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpcs_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpcs_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpmd_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpmd_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpstan_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpstan_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_rector_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_rector_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (97)
.vortex/installer/phpcs.xml.vortex/installer/rector.php.vortex/installer/tests/Functional/Command/BuildCommandTest.php.vortex/installer/tests/Functional/Command/CheckRequirementsCommandTest.php.vortex/installer/tests/Functional/Command/InstallCommandTest.php.vortex/installer/tests/Functional/Command/SchemaValidateCommandTest.php.vortex/installer/tests/Functional/Handlers/AbstractHandlerProcessTestCase.php.vortex/installer/tests/Functional/Handlers/AiCodeInstructionsHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/BaselineHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/CiProviderHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/CodeProviderHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/CustomModulesHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/DatabaseDownloadSourceHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/DependencyUpdatesProviderHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/DeployTypeHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/DocsHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/HostingProjectNameHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/HostingProviderHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/MigrationDownloadSourceHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/MigrationHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/ModulesHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/NamesHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/NotificationChannelsHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/ProfileHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/ProvisionTypeHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/PullRequestHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/ServicesHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/StarterHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/ThemeHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/TimezoneHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/ToolsHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/VersionSchemeHandlerProcessTest.php.vortex/installer/tests/Unit/ConfigTest.php.vortex/installer/tests/Unit/ConverterTest.php.vortex/installer/tests/Unit/Downloader/ArchiverTest.php.vortex/installer/tests/Unit/Downloader/ArtifactTest.php.vortex/installer/tests/Unit/Downloader/RepositoryDownloaderTest.php.vortex/installer/tests/Unit/EnvTest.php.vortex/installer/tests/Unit/FileTest.php.vortex/installer/tests/Unit/GitTest.php.vortex/installer/tests/Unit/Handlers/AbstractHandlerDiscoveryTestCase.php.vortex/installer/tests/Unit/Handlers/AbstractHandlerTypeTest.php.vortex/installer/tests/Unit/Handlers/AiCodeInstructionsHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/BaselineHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/CiProviderHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/CodeProviderHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/CustomModulesHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/DatabaseDownloadSourceHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/DatabaseImageHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/DependencyUpdatesProviderHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/DeployTypesHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/DocsHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/DomainHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/HostingProjectNameHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/HostingProviderHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/MigrationDownloadSourceHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/MigrationHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/ModulePrefixHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/ModulesHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/NamesHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/NotificationChannelsHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/ProfileHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/ProvisionTypeHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/PullRequestHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/ServicesHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/StarterHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/ThemeHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/TimezoneHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/ToolsHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/VersionSchemeHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/WebrootHandlerDiscoveryTest.php.vortex/installer/tests/Unit/JsonManipulatorTest.php.vortex/installer/tests/Unit/Logger/FileLoggerTest.php.vortex/installer/tests/Unit/Prompts/InstallerPresenterTest.php.vortex/installer/tests/Unit/Prompts/PromptTypeTest.php.vortex/installer/tests/Unit/Runner/AbstractRunnerTest.php.vortex/installer/tests/Unit/Runner/CommandRunnerTest.php.vortex/installer/tests/Unit/Runner/ProcessRunnerTest.php.vortex/installer/tests/Unit/Schema/AgentHelpTest.php.vortex/installer/tests/Unit/Schema/SchemaGeneratorTest.php.vortex/installer/tests/Unit/StringsTest.php.vortex/installer/tests/Unit/TaskTest.php.vortex/installer/tests/Unit/TuiTest.php.vortex/installer/tests/Unit/Utils/OptionsResolverTest.php.vortex/installer/tests/Unit/ValidatorTest.php.vortex/installer/tests/Unit/YamlTest.php.vortex/tests/phpunit/Functional/DockerComposeTest.php.vortex/tests/rector.phprector.phptests/phpunit/CircleCiConfigTest.phptests/phpunit/Drupal/DatabaseSettingsTest.phptests/phpunit/Drupal/EnvironmentSettingsTest.phptests/phpunit/Drupal/SwitchableSettingsTest.phpweb/modules/custom/ys_base/tests/src/Kernel/ExampleTest.phpweb/modules/custom/ys_base/tests/src/Unit/ExampleTest.phpweb/themes/custom/your_site_theme/tests/src/Kernel/ExampleTest.phpweb/themes/custom/your_site_theme/tests/src/Unit/ExampleTest.php
Member
Author
|
Member
Author
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2367 +/- ##
==========================================
- Coverage 79.18% 78.70% -0.49%
==========================================
Files 125 118 -7
Lines 6588 6432 -156
Branches 44 0 -44
==========================================
- Hits 5217 5062 -155
+ Misses 1371 1370 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AlexSkrypnyk
force-pushed
the
feature/2362-yield-settings-tests
branch
from
2a7fbfb to
c903c4b
Compare
|
Member
Author
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.vortex/installer/tests/Functional/Command/BuildCommandTest.php (1)
396-414:⚠️ Potential issue | 🟡 MinorActually fail the docker-config branch in this scenario.
Line 397 still returns
EXIT_SUCCESSfor every command. With Line 413 set toNULL, this case covers an unreadable config response, not a faileddocker compose configinvocation, so the non-zero exit path stays untested.🧪 Proposed fix
yield 'Build success hides site URL when docker compose fails' => [ - 'exit_code_callback' => fn(string $current_command): int => RunnerInterface::EXIT_SUCCESS, + 'exit_code_callback' => fn(string $current_command): int => str_contains($current_command, 'docker') + ? RunnerInterface::EXIT_FAILURE + : RunnerInterface::EXIT_SUCCESS, 'command_inputs' => ['--skip-requirements-check' => TRUE], 'expect_failure' => FALSE, 'output_assertions' => array_merge(🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.vortex/installer/tests/Functional/Command/BuildCommandTest.php around lines 396 - 414, The test currently returns RunnerInterface::EXIT_SUCCESS for every invocation so the non-zero docker-compose path isn't exercised; update the 'exit_code_callback' closure to inspect the $current_command and return a non-zero exit (e.g. RunnerInterface::EXIT_FAILURE) when the command string contains 'docker compose config' (and keep returning EXIT_SUCCESS for other commands), so the docker-compose config failure path is actually tested while leaving 'docker_compose_url' as NULL to represent the failing invocation scenario.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.vortex/installer/tests/Functional/Command/BuildCommandTest.php:
- Around line 396-414: The test currently returns RunnerInterface::EXIT_SUCCESS
for every invocation so the non-zero docker-compose path isn't exercised; update
the 'exit_code_callback' closure to inspect the $current_command and return a
non-zero exit (e.g. RunnerInterface::EXIT_FAILURE) when the command string
contains 'docker compose config' (and keep returning EXIT_SUCCESS for other
commands), so the docker-compose config failure path is actually tested while
leaving 'docker_compose_url' as NULL to represent the failing invocation
scenario.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 40dc971c-376b-4219-b59c-eeec8ed127dd
⛔ Files ignored due to path filters (106)
.vortex/installer/tests/Fixtures/handler_process/_baseline/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/web/modules/custom/sw_base/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/web/modules/custom/sw_base/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/web/themes/custom/star_wars/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/web/themes/custom/star_wars/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/ciprovider_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/ciprovider_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_all_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_all_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_none_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_none_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deps_updates_provider_ci_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deps_updates_provider_ci_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/modules/custom/sw_base/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/modules/custom/sw_base/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/themes/custom/star_wars/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/themes/custom/star_wars/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/modules/custom/sw_base/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/modules/custom/sw_base/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/themes/custom/star_wars/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/themes/custom/star_wars/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_disabled_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_disabled_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_disabled_lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_acquia/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_acquia/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_ftp/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_ftp/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_lagoon/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_s3/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_s3/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_url/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_url/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_config_split/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_config_split/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_environment_indicator/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_environment_indicator/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_robotstxt/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_seckit/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_seckit_shield_stage_file_proxy/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_seckit_shield_stage_file_proxy/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_shield/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_shield/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_stage_file_proxy/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_none/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_none/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/names/web/modules/custom/the_force_base/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/names/web/modules/custom/the_force_base/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/names/web/themes/custom/lightsaber/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/names/web/themes/custom/lightsaber/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/non_interactive_config_file/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/provision_database_lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/services_no_redis/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/services_none/tests/phpunit/Drupal/SwitchableSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/theme_claro/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/theme_custom/web/themes/custom/light_saber/tests/src/Kernel/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/theme_custom/web/themes/custom/light_saber/tests/src/Unit/ExampleTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/theme_olivero/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/theme_stark/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/timezone_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/timezone_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpcs_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpcs_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpmd_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpmd_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpstan_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpstan_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_rector_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_rector_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_circleci/tests/phpunit/CircleCiConfigTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/rector.phpis excluded by!.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (98)
.vortex/installer/phpcs.xml.vortex/installer/rector.php.vortex/installer/src/Prompts/Handlers/Tools.php.vortex/installer/tests/Functional/Command/BuildCommandTest.php.vortex/installer/tests/Functional/Command/CheckRequirementsCommandTest.php.vortex/installer/tests/Functional/Command/InstallCommandTest.php.vortex/installer/tests/Functional/Command/SchemaValidateCommandTest.php.vortex/installer/tests/Functional/Handlers/AbstractHandlerProcessTestCase.php.vortex/installer/tests/Functional/Handlers/AiCodeInstructionsHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/BaselineHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/CiProviderHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/CodeProviderHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/CustomModulesHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/DatabaseDownloadSourceHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/DependencyUpdatesProviderHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/DeployTypeHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/DocsHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/HostingProjectNameHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/HostingProviderHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/MigrationDownloadSourceHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/MigrationHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/ModulesHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/NamesHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/NotificationChannelsHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/ProfileHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/ProvisionTypeHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/PullRequestHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/ServicesHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/StarterHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/ThemeHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/TimezoneHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/ToolsHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/VersionSchemeHandlerProcessTest.php.vortex/installer/tests/Unit/ConfigTest.php.vortex/installer/tests/Unit/ConverterTest.php.vortex/installer/tests/Unit/Downloader/ArchiverTest.php.vortex/installer/tests/Unit/Downloader/ArtifactTest.php.vortex/installer/tests/Unit/Downloader/RepositoryDownloaderTest.php.vortex/installer/tests/Unit/EnvTest.php.vortex/installer/tests/Unit/FileTest.php.vortex/installer/tests/Unit/GitTest.php.vortex/installer/tests/Unit/Handlers/AbstractHandlerDiscoveryTestCase.php.vortex/installer/tests/Unit/Handlers/AbstractHandlerTypeTest.php.vortex/installer/tests/Unit/Handlers/AiCodeInstructionsHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/BaselineHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/CiProviderHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/CodeProviderHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/CustomModulesHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/DatabaseDownloadSourceHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/DatabaseImageHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/DependencyUpdatesProviderHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/DeployTypesHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/DocsHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/DomainHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/HostingProjectNameHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/HostingProviderHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/MigrationDownloadSourceHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/MigrationHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/ModulePrefixHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/ModulesHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/NamesHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/NotificationChannelsHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/ProfileHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/ProvisionTypeHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/PullRequestHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/ServicesHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/StarterHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/ThemeHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/TimezoneHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/ToolsHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/VersionSchemeHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/WebrootHandlerDiscoveryTest.php.vortex/installer/tests/Unit/JsonManipulatorTest.php.vortex/installer/tests/Unit/Logger/FileLoggerTest.php.vortex/installer/tests/Unit/Prompts/InstallerPresenterTest.php.vortex/installer/tests/Unit/Prompts/PromptTypeTest.php.vortex/installer/tests/Unit/Runner/AbstractRunnerTest.php.vortex/installer/tests/Unit/Runner/CommandRunnerTest.php.vortex/installer/tests/Unit/Runner/ProcessRunnerTest.php.vortex/installer/tests/Unit/Schema/AgentHelpTest.php.vortex/installer/tests/Unit/Schema/SchemaGeneratorTest.php.vortex/installer/tests/Unit/StringsTest.php.vortex/installer/tests/Unit/TaskTest.php.vortex/installer/tests/Unit/TuiTest.php.vortex/installer/tests/Unit/Utils/OptionsResolverTest.php.vortex/installer/tests/Unit/ValidatorTest.php.vortex/installer/tests/Unit/YamlTest.php.vortex/tests/phpunit/Functional/DockerComposeTest.php.vortex/tests/rector.phprector.phptests/phpunit/CircleCiConfigTest.phptests/phpunit/Drupal/DatabaseSettingsTest.phptests/phpunit/Drupal/EnvironmentSettingsTest.phptests/phpunit/Drupal/SwitchableSettingsTest.phpweb/modules/custom/ys_base/tests/src/Kernel/ExampleTest.phpweb/modules/custom/ys_base/tests/src/Unit/ExampleTest.phpweb/themes/custom/your_site_theme/tests/src/Kernel/ExampleTest.phpweb/themes/custom/your_site_theme/tests/src/Unit/ExampleTest.php
Member
Author
|
Member
Author
|
AlexSkrypnyk
added
the
AUTOMERGE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2362
Summary by CodeRabbit
Chores
Tests