Skip to content

Added consistent Chromium flags to Behat and PHPUnit configs.#2378

Merged
AlexSkrypnyk merged 1 commit intomainfrom
feature/chromium-flags
Mar 13, 2026
Merged

Added consistent Chromium flags to Behat and PHPUnit configs.#2378
AlexSkrypnyk merged 1 commit intomainfrom
feature/chromium-flags

Conversation

@AlexSkrypnyk
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk commented Mar 13, 2026

Summary by CodeRabbit

  • Chores
    • Updated automated browser test configuration to disable popup blocking and use a 1920x1080 window for deterministic behavior.
  • Documentation
    • Added documentation entries describing the popup-blocking disable flag and the fixed 1920x1080 viewport for test screenshots.

@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e089a5be-54dd-4c24-8b21-c16462ef8b17

📥 Commits

Reviewing files that changed from the base of the PR and between 1f60e41 and b34af80.

⛔ Files ignored due to path filters (4)
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/behat.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/phpunit.xml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/hosting_acquia/behat.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/behat.yml is excluded by !.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (4)
  • .vortex/docs/content/tools/behat.mdx
  • .vortex/docs/content/tools/phpunit.mdx
  • behat.yml
  • phpunit.xml

Walkthrough

Adds Chrome command-line flags to test configurations and documentation: --disable-popup-blocking is added to Behat and PHPUnit WebDriver chromeOptions; Behat also adds --window-size=1920,1080. Docs updated to document the new flags.

Changes

Cohort / File(s) Summary
Chrome test configs
behat.yml, phpunit.xml
Appended --disable-popup-blocking to goog:chromeOptions.args in both files; behat.yml also appends --window-size=1920,1080. No other config or control-flow changes.
Documentation updates
.vortex/docs/content/tools/behat.mdx, .vortex/docs/content/tools/phpunit.mdx
Added entries documenting --disable-popup-blocking and --window-size=1920,1080 where applicable.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

AUTOMERGE

Poem

🐰 I hopped into configs, tidy and quick,

Popups allowed, and the window's picked,
Tests snap screenshots at one-nine-two-oh,
Chrome hums along, row after row,
A rabbit's tweak — small, precise, and slick.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding Chromium flags (--disable-popup-blocking and --window-size) consistently across Behat and PHPUnit configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/chromium-flags
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

This comment has been minimized.

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-03-13 00:27:25

 Summary:
  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)

Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-03-13 00:30:20

 Summary:
  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)

Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-03-13 00:30:34

 Summary:
  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)

Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.91%. Comparing base (21ad14c) to head (b34af80).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2378      +/-   ##
==========================================
- Coverage   79.40%   78.91%   -0.49%     
==========================================
  Files         125      118       -7     
  Lines        6680     6521     -159     
  Branches       44        0      -44     
==========================================
- Hits         5304     5146     -158     
+ Misses       1376     1375       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/chromium-flags branch from 1f60e41 to b34af80 Compare March 13, 2026 00:34
@github-actions
Copy link

Code Coverage Report:
  2026-03-13 00:40:21

 Summary:
  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)

Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-03-13 00:41:06

 Summary:
  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)

Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-03-13 00:43:57

 Summary:
  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)

Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-03-13 00:44:07

 Summary:
  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)

Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk AlexSkrypnyk merged commit fe4d1fd into main Mar 13, 2026
30 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/chromium-flags branch March 13, 2026 00:54
@github-project-automation github-project-automation bot moved this from BACKLOG to Release queue in Vortex Mar 13, 2026
@AlexSkrypnyk AlexSkrypnyk added this to the 1.37.0 milestone Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Released in 1.37.0

Development

Successfully merging this pull request may close these issues.

1 participant