[#132] Add Highlight.js syntax highlighter module. #138
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,6 +47,7 @@ module: | |
| gin_toolbar: 0 | ||
| google_tag: 0 | ||
| help: 0 | ||
| highlight_js: 0 | ||
| history: 0 | ||
| image: 0 | ||
| image_captcha: 0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,12 @@ | ||||||||||
| copy_enable: true | ||||||||||
| copy_bg_transparent: false | ||||||||||
| copy_bg_color: '#4243b1' | ||||||||||
| copy_txt_color: '#ffffff' | ||||||||||
| copy_btn_text: '' | ||||||||||
| copy_success_text: '' | ||||||||||
| success_txt_color: '#ffffff' | ||||||||||
| role_copy_access: { } | ||||||||||
| languages: { } | ||||||||||
|
Comment on lines
+8
to
+9
There was a problem hiding this comment. Fix YAML lint: too many spaces inside empty braces on both lines. YAMLlint flags both 🔧 Proposed fix-role_copy_access: { }
-languages: { }
+role_copy_access: {}
+languages: {}📝 Committable suggestion
Suggested change
🧰 Tools🪛 YAMLlint (1.38.0)[error] 8-8: too many spaces inside empty braces (braces) [error] 9-9: too many spaces inside empty braces (braces) 🤖 Prompt for AI Agents |
||||||||||
| theme: github | ||||||||||
| success_bg_transparent: false | ||||||||||
| success_bg_color: '#4243b1' | ||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,5 @@ | ||||||
| highlight_js.gherkin: | ||||||
| js: | ||||||
| https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/languages/gherkin.min.js: { type: external, minified: true } | ||||||
|
There was a problem hiding this comment. Fix YAML lint: remove extra spaces inside braces. YAMLlint reports 🔧 Proposed fix- https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/languages/gherkin.min.js: { type: external, minified: true }
+ https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/languages/gherkin.min.js: {type: external, minified: true}📝 Committable suggestion
Suggested change
🧰 Tools🪛 YAMLlint (1.38.0)[error] 3-3: too many spaces inside braces (braces) [error] 3-3: too many spaces inside braces (braces) 🤖 Prompt for AI Agents |
||||||
| dependencies: | ||||||
| - highlight_js/highlight_js.js | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Drupal\do_base\Hook; | ||
|
|
||
| use Drupal\Core\Hook\Attribute\Hook; | ||
|
|
||
| /** | ||
| * Library info alter hooks for do_base module. | ||
| */ | ||
| final class LibraryInfoAlterHook { | ||
|
|
||
| /** | ||
| * Implements hook_library_info_alter(). | ||
| * | ||
| * Attaches Gherkin language support whenever Highlight.js is loaded. | ||
| * The CDN common bundle does not include Gherkin, so we load it separately. | ||
| */ | ||
| #[Hook('library_info_alter')] | ||
| public function alter(array &$libraries, string $extension): void { | ||
| if ($extension === 'highlight_js' && isset($libraries['highlight_js.custom'])) { | ||
| $libraries['highlight_js.custom']['dependencies'][] = 'do_base/highlight_js.gherkin'; | ||
| } | ||
| } | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
composer.lockmust be committed alongside this change.The PR description acknowledges this is deferred, but shipping without an updated
composer.lockmeans the resolved transitive dependency tree is undefined for all environments. CI may resolve a different constraint than intended, and reproducible builds are broken until the lock file is committed.🤖 Prompt for AI Agents