Fixed Env indicator, Coffee and paragraphs library permissions for site Administrator.

[AlexSkrypnyk]

Summary by CodeRabbit

• New Features

  • Expanded site administrator capabilities to include access and management of Coffee, Environment Indicator, and Paragraphs Library modules.
  • Added permissions for creating and editing paragraph library items for site administrators.

• Bug Fixes

  • Removed revision comparison and viewing permissions for authenticated users.

• Tests

  • Introduced new automated tests to verify site administrator access to Coffee, Environment Indicator, and Paragraphs Library features.
  • Updated existing tests to align with new role permissions.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update role configurations and add new Behat feature tests. The "authenticated" role loses Diff module permissions, while the "civictheme_site_administrator" role gains dependencies and permissions for Coffee, Environment Indicator, and Paragraphs Library modules. New feature tests verify access to these modules and update an existing test to use the updated administrator role.

Changes

Cohort / File(s)	Change Summary
Authenticated Role Configuration config/default/user.role.authenticated.yml	Removes "diff" module dependency and associated permissions ("compare revisions", "view revisions") from the authenticated user role.
Site Administrator Role Enhancements config/default/user.role.civictheme_site_administrator.yml	Adds dependencies on "coffee", "environment_indicator", and "paragraphs_library" modules; grants related permissions for access and administration, including paragraph library item creation/editing.
New Behat Feature Tests tests/behat/features/coffee_access.feature, tests/behat/features/environment_indicator_access.feature, tests/behat/features/paragraphs_library_access.feature	Adds new feature tests to verify site administrator access to Coffee, Environment Indicator, and Paragraphs Library modules, including UI and HTTP response checks.
Updated Behat Test for Diff Module tests/behat/features/diff.feature	Changes login role from "Administrator" to "civictheme_site_administrator" in the Diff module access scenario.

Sequence Diagram(s)

sequenceDiagram
    participant SiteAdmin as Site Administrator
    participant Drupal as Drupal Site
    participant Modules as Coffee/EnvIndicator/ParagraphsLibrary

    SiteAdmin->>Drupal: Login as civictheme_site_administrator
    SiteAdmin->>Drupal: Visit homepage or module-specific page
    Drupal->>Modules: Check permissions for module access
    Modules-->>Drupal: Grant access if permissions present
    Drupal-->>SiteAdmin: Render page with module UI elements

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Lite

📥 Commits

Reviewing files that changed from the base of the PR and between c2aa4ec and e85eed5.

📒 Files selected for processing (6)

• config/default/user.role.authenticated.yml (0 hunks)
• config/default/user.role.civictheme_site_administrator.yml (5 hunks)
• tests/behat/features/coffee_access.feature (1 hunks)
• tests/behat/features/diff.feature (1 hunks)
• tests/behat/features/environment_indicator_access.feature (1 hunks)
• tests/behat/features/paragraphs_library_access.feature (1 hunks)

💤 Files with no reviewable changes (1)

• config/default/user.role.authenticated.yml

🧰 Additional context used

📓 Path-based instructions (1)

tests/behat/**/*.feature

📄 CodeRabbit Inference Engine (CLAUDE.md)

tests/behat/**/*.feature: All Behat feature files must use the standard user story format: 'As a [user type]\nI want to [action]\nSo that [benefit]'
Use consistent user types in Behat feature files: 'site visitor', 'site administrator', and 'content editor'
Do not use commas or periods in user story statements within Behat feature files

Files:

• tests/behat/features/paragraphs_library_access.feature
• tests/behat/features/coffee_access.feature
• tests/behat/features/environment_indicator_access.feature
• tests/behat/features/diff.feature

🧠 Learnings (3)

📓 Common learnings

Learnt from: CR
PR: drevops/website#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-06T02:21:34.266Z
Learning: Applies to tests/behat/**/*.feature : Use consistent user types in Behat feature files: 'site visitor', 'site administrator', and 'content editor'

Learnt from: CR
PR: drevops/vortex#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-06T00:44:35.051Z
Learning: Applies to tests/behat/**/*.feature : Use consistent user types in Behat feature files: 'site visitor', 'site administrator', and 'content editor'

Learnt from: CR
PR: drevops/website#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-06T02:21:34.266Z
Learning: Applies to tests/behat/**/*.feature : All Behat feature files must use the standard user story format: 'As a [user type]\nI want to [action]\nSo that [benefit]'

Learnt from: CR
PR: drevops/vortex#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-06T00:44:35.051Z
Learning: Applies to tests/behat/**/*.feature : All Behat feature files must use the standard user story format: 'As a [user type]\nI want to [action]\nSo that [benefit]'

📚 Learning: applies to tests/behat/**/*.feature : use consistent user types in behat feature files: 'site visito...

Learnt from: CR
PR: drevops/website#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-06T02:21:34.266Z
Learning: Applies to tests/behat/**/*.feature : Use consistent user types in Behat feature files: 'site visitor', 'site administrator', and 'content editor'

Applied to files:

• tests/behat/features/paragraphs_library_access.feature
• tests/behat/features/coffee_access.feature
• tests/behat/features/environment_indicator_access.feature
• tests/behat/features/diff.feature

📚 Learning: applies to tests/behat/**/*.feature : all behat feature files must use the standard user story forma...

Learnt from: CR
PR: drevops/website#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-06T02:21:34.266Z
Learning: Applies to tests/behat/**/*.feature : All Behat feature files must use the standard user story format: 'As a [user type]\nI want to [action]\nSo that [benefit]'

Applied to files:

• tests/behat/features/paragraphs_library_access.feature
• tests/behat/features/coffee_access.feature
• tests/behat/features/environment_indicator_access.feature
• tests/behat/features/diff.feature

🔇 Additional comments (7)

config/default/user.role.civictheme_site_administrator.yml (3)

27-36: LGTM! Module dependencies correctly added.

The module dependencies for coffee, environment_indicator, and paragraphs_library are properly added and maintain alphabetical ordering within the module section.

---

55-79: LGTM! Access and administration permissions properly configured.

The permissions for the three modules are correctly added:

• access coffee and access environment indicator provide basic access
• administer environment indicator settings and administer paragraphs library provide administrative capabilities

The permissions maintain alphabetical ordering within their respective sections.

---

105-177: LGTM! Paragraphs library content management permissions added.

The create paragraph library item and edit paragraph library item permissions enable site administrators to manage paragraph library content, completing the permission set for the paragraphs_library module.

tests/behat/features/diff.feature (1)

9-9: LGTM! Role updated correctly.

The role change from "Administrator" to "civictheme_site_administrator" aligns with the updated role configuration and ensures the test uses the proper role.

tests/behat/features/coffee_access.feature (1)

1-12: LGTM! Well-structured Behat feature file.

The feature file correctly:

• Uses the approved user type "site administrator"
• Follows the standard user story format
• Uses appropriate tags (@api @javascript)
• Tests the coffee module functionality by checking for the coffee form wrapper element
• Aligns with the permissions granted in the role configuration

tests/behat/features/environment_indicator_access.feature (1)

1-12: LGTM! Environment indicator test properly structured.

The feature file correctly:

• Uses the approved user type "site administrator"
• Follows the standard user story format
• Uses appropriate tags (@api @javascript)
• Tests environment indicator functionality by checking for toolbar styling modifications
• Aligns with the "access environment indicator" permission granted in the role configuration

tests/behat/features/paragraphs_library_access.feature (1)

1-18: LGTM! Comprehensive paragraphs library testing.

The feature file correctly:

• Uses the approved user type "site administrator"
• Follows the standard user story format
• Uses appropriate @api tags
• Tests both read access (paragraphs library page) and write access (paragraph creation)
• Aligns with the "administer paragraphs library" and "create paragraph library item" permissions granted in the role configuration
• Includes appropriate HTTP status code validation

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.