Conversation
Drop Oh-My-Zsh, Powerlevel10k, and the stow-managed zsh package. Shell config now lives at ~/.zshrc (untracked) with Starship prompt. Add starship/ stow package for managed starship.toml. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PR Review: Replace zsh/OMZ with Starship promptOverall this is a clean simplification — removing ~130 lines of mostly-commented OMZ boilerplate is a clear win, and the A few things worth addressing: Bug:
|
Replace Rose Pine statusline.conf with catppuccin/tmux plugin. Square separators, transparent bar bg, lavender active tab number, surface_0 active tab text and module text bg, padded icons. Switch Ghostty theme to Catppuccin Macchiato, remove bg opacity. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PR Review: Replace zsh/OMZ with Starship promptOverall this is a clean, well-motivated change. The Starship migration and tmux improvements are solid. A few things worth flagging: Untracked
|
Replace zsh/OMZ and alacritty references with Starship and Ghostty. Update stow package list and key tools section. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PR ReviewOverall this is a clean, well-scoped change. Migration from OMZ to Starship simplifies the shell config considerably, and the consistent Catppuccin Macchiato theming across ghostty/tmux/starship is a nice touch. Observations and Questionszsh/ removal The deleted tmux submodule The catppuccin/tmux plugin is added as a git submodule, but CLAUDE.md setup instructions do not mention running submodule init after cloning. New installs will have an empty plugins directory and a broken tmux statusline. Suggestion -- add to the CLAUDE.md Setup section: tmux.conf -- extended keys The This may explain any keybinding edge cases with Ghostty. catppuccin.conf -- window path display
SummaryTwo concrete things worth addressing:
Everything else looks solid. |
Re-adds zsh/.zshrc to dotfiles after OMZ→Starship migration. Secrets are split into ~/.zshrc.local (untracked) sourced at runtime. Includes .zshrc.local.example as new-machine setup template. Also makes the `cl` alias portable via $HOME. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The plugin was tracked as a gitlink (mode 160000) without a .gitmodules file, causing fresh clones to get an empty directory and a broken tmux statusline. Removed the submodule gitlink and added the plugin files as regular tracked files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PR Review: Replace zsh/OMZ with Starship promptOverall this is a solid cleanup — removing OMZ reduces shell startup time dramatically and Starship is a great fit for a minimal, fast prompt. A few things worth discussing: Vendored catppuccin/tmux plugin (main concern)The bulk of this PR (+2,400 lines) is the entire
Suggested alternatives:
Any of these avoids carrying upstream CI infra and binary blobs in the dotfiles history. Stale
|
This reverts commit 93459cd.
Replace broken gitlink with a proper submodule entry. Pins to v2.1.3 (b2f219c), the same commit previously referenced. git submodule update --init on fresh clone populates the plugin. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
PR Review - Replace zsh/OMZ with Starship prompt. Good cleanup overall. Removing OMZ and p10k cuts significant startup overhead, and the secrets separation via .zshrc.local is a clear improvement. BUG: alias gk uses a non-existent git command. git kill is not a standard command and will error. This is likely meant to be: alias gk=git branch | fzf | xargs git branch -d OBSERVATION 1 - Hardcoded Apple Silicon Homebrew path: /opt/homebrew is ARM-only. Intel Macs use /usr/local. The autosuggestions and syntax-highlighting sources will silently fail on Intel hardware. Fine for M-series only setup, but worth a note in CLAUDE.md. OBSERVATION 2 - bind x kill-pane removes confirmation: Overrides the default confirm-before behavior. Easy to accidentally close the wrong pane. OBSERVATION 3 - Submodule not documented in setup: Fresh clones need git submodule update --init before the tmux statusline works. Missing from CLAUDE.md setup section. OBSERVATION 4 - PR description vs final state: The summary says .zshrc now lives outside dotfiles, but the final commit re-adds zsh/.zshrc to the stow package. The stow install command in CLAUDE.md is also missing zsh. POSITIVES: Shell startup at ~0.13s is a solid win. source fzf --zsh is the modern approach. .zshrc.local.example bootstrap template is a great pattern. pane_current_path on splits is a quality-of-life win. history-limit 50000 and escape-time 0 are solid improvements. |
Summary
zsh/package (.zshrc,.zsh_profile)starship/stow package withstarship.tomlconfig~/.zshrcnow lives outside dotfiles (Starship, no OMZ, no p10k)Test plan
🤖 Generated with Claude Code