fix: prevent script injection in analysis workflow#327
Merged
Conversation
Move user-controllable workflow_run expressions (head_branch, head_sha, pull request number) to environment variables instead of interpolating them directly in run blocks. Fixes SonarCloud blocker S7630.
Move checks, pull-requests, and actions permissions from workflow level to the specific jobs that need them. Follows principle of least privilege. Fixes SonarCloud S8233 and S8264.
Code Coverage
Updated for commit 4bc0210 |
Unit Tests 62 files ±0 62 suites ±0 3m 11s ⏱️ +12s Results for commit 4bc0210. ± Comparison against base commit c62a51f. This pull request removes 39 and adds 39 tests. Note that renamed tests count towards both. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughGitHub Actions workflow refactored to move permissions from top-level to job-level scope. Environment variables introduced to reference GitHub event workflow data. Updated Sonar and coverage steps to use these variables for PR metadata and API calls instead of inline expressions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_runexpressions (head_branch,head_sha, PR number) to environment variables instead of interpolating them directly inrunblocksContext
The
analysis.ymlworkflow introduced in #324 interpolatedgithub.event.workflow_run.head_branchdirectly in a shell script. An attacker could craft a branch name with shell metacharacters to inject arbitrary commands. The fix passes all user-controllable values throughenv:instead of${{ }}inrun:blocks.Test plan
Summary by CodeRabbit