Luke/dpe 3219 candle api trades integration #187
Conversation
# Conflicts: # protocol
…scription succeeded
…logic. Fixed bug when cleaning up subscriptions. Added more unit tests.
| } | ||
| } | ||
|
|
||
| this.subscribeToApi(); |
There was a problem hiding this comment.
i feel sus about this implementation...
we are subscribing to the API on object creation, but we don't have any information about the subscription from the consumer's POV.
e.g. we do const marketDataApiSubscription = new ApiSubscription(...)
but this code don't know anything about the underlying subscription, whereas we'd usually have something like const subscription = await marketDataApiSubscription.subscribe()
There was a problem hiding this comment.
Ok coming back to this yeah the idea was that apisubscription IS A SUBSCRIPTION .. it shouldn't exist without a subscriber/without being subscribed .. so it's got a minimal interface where the only public methods available are to add or remove subscribers (and it will automatically unsubscribe when there are no subscribers left) .. I'll wait to see what you think , I don't think it's that bad tbh 🧐
…allow resetting candles in tvfeed class
…the last subscriber unsubscribes
…tiplex websocket class. Removed previous "health check" logic.
|
|
||
| // Check if we've exceeded the maximum reconnect attempts | ||
| if (this.reconnectAttempts >= this.maxAttemptsCount) { | ||
| throw new Error( |
There was a problem hiding this comment.
will it break the UI if the UI doesn't catch this error? is it better to just log the error?
See associated UI changes in this PR :: https://github.com/drift-labs/protocol-v2-mono/pull/3593