Skip to content

sdk: ref price offset calc #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wphan merged 1 commit into from
Jul 18, 2025
Merged

sdk: ref price offset calc #1750

wphan merged 1 commit into from
Jul 18, 2025

Conversation

@wphan
Copy link
Member

@wphan wphan commented Jul 16, 2025

No description provided.

wphan
wphan commented Jul 16, 2025
View reviewed changes
sdk/src/math/amm.ts
maxOffsetInPrice.mul(new BN(-1)),
maxOffsetInPrice
new BN(maxOffsetPct).mul(new BN(-1)),
new BN(maxOffsetPct)
Copy link
Member Author

@wphan wphan Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust:

protocol-v2/programs/drift/src/math/amm_spread.rs

Lines 606 to 610 in c764113

let inventory_pct = liquidity_fraction
.cast::<i64>()?
.safe_mul(max_offset_pct)?
.safe_div(PERCENTAGE_PRECISION.cast::<i64>()?)?
.clamp(-max_offset_pct, max_offset_pct);

@wphan wphan merged commit de8dc6d into master Jul 18, 2025
30 of 33 checks passed
@wphan wphan deleted the wphan/ref-price-offset-sdk-bug branch July 18, 2025 00:32
harsh4786 pushed a commit to harsh4786/drift-v2 that referenced this pull request Oct 23, 2025
@wphan @harsh4786
sdk: ref price offset calc (drift-labs#1750)
32af6d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wphan