EloquentWhereTypeHintClosureParameterRector uses database contract on eloquent model -> relationship -> where?

[ghbob]

e.g.

$this->someModel
  ->someHasManyRelationship()
  ->where(...)
  ->where(function ($query)

makes the $query a Illuminate\Contracts\Database\Query\Builder

I'd expect Illuminate\Contracts\Database\Eloquent\Builder though?

A simple

Model::where(function ($query)

on the other hand is refactored to use Illuminate\Contracts\Database\Eloquent\Builder.

[ghbob]

maybe just because these chained ->where() clauses could be both, Illuminate/Database/Query or Illuminate/Database/Eloquent?
Would it be possible to detect these?

[ghbob]

but even in a function where we explicitly pass an eloquent builder into the where function is refactored to the database contract?

private static function someFunction(Eloquent/Builder $query): Eloquent/Builder {
 $query->where(static function (\Illuminate\Contracts\Database\Query\Builder $query) 

[calebdw]

The contracts should not be used at all, they are just stubs in the framework for ides and serve no purpose at all

[ghbob]

The contracts should not be used at all, they are just stubs in the framework for ides and serve no purpose at all

ok, so you are saying both
EloquentWhereRelationTypeHintingParameterRector (rule)
EloquentWhereTypeHintClosureParameterRector | (rule)

should not be used at all?
They are in the LaravelSetList::LARAVEL_TYPE_DECLARATIONS after all.

or that the correct ones would be:

Illuminate\Contracts\Database\Query\Builder → Illuminate\Database\Query\Builder
Illuminate\Contracts\Database\Eloquent\Builder → Illuminate\Database\Eloquent\Builder
?

I assume since the contracts mixin the implementations the IDE and Larastan/PHPStan are fine with it anyway?

references:
https://api.laravel.com/docs/12.x/Illuminate/Contracts/Database/Query/Builder.html
https://api.laravel.com/docs/12.x/Illuminate/Contracts/Database/Eloquent/Builder.html
https://api.laravel.com/docs/12.x/Illuminate/Database/Query/Builder.html
https://api.laravel.com/docs/12.x/Illuminate/Database/Eloquent/Builder.html

[calebdw]

The contracts are pointless and are not used at all:

The rectors should be using the actual EloquentBuilder and QueryBuilder classes

[peterfox]

I'm not sure if the intention is to not use the contracts for implementations or to not use them for type hinting. I think it's the former, that you should still use them as type hints for things like closures.

A lot with this rule brings complexity that probably wasn't initially considered when I wrote. Namely in some methods you want the relationship type type hinted vs just a contract.

I can think of a few ways to potentially improve it by doing more interrogation of the object being called.