Skip to content

Conversation

@zingimmick
Copy link
Contributor

@zingimmick zingimmick commented Mar 26, 2021

When LaravelSetList::LARAVEL_60 applied, the code changes as below:

-DB::connection($connection)->table($table);
+DB::connection($connection)->table($table, 'null');

Expected Behavior:

-DB::connection($connection)->table($table);
+DB::connection($connection)->table($table, null);

Related rectorphp/rector#5997

@zingimmick
Copy link
Contributor Author

All checks have failed, #3 will fix it.

@TomasVotruba
Copy link
Collaborator

Thanks 👍

You can send these in 1 PR next time, so have the CI passing after merge

@TomasVotruba TomasVotruba merged commit ee18ec2 into driftingly:main Mar 29, 2021
@zingimmick zingimmick deleted the stripping-quotation-marks-of-argument-default-value branch September 26, 2021 02:29
driftingly pushed a commit that referenced this pull request Jul 31, 2023
* Remove BetterNodeFinder dependency from AddGenericReturnTypeToRelationsRector

* Removed some usages of BetterNodeFinder and MultiInstanceofChecker

* Removed usages of BetterNodeFinder and parent nodes from MigrateToSimplifiedAttributeRector

* Removed usages of BetterNodeFinder and parent nodes from RedirectBackToBackHelperRector

* Removed usages of BetterNodeFinder and parent nodes from RedirectRouteToToRouteHelperRector.php

* Removed usages of BetterNodeFinder and parent nodes from ReplaceFakerInstanceWithHelperRector

* Fix RequestStaticValidateToInjectRector

* Refactor RequestStaticValidateToInjectRector

* Support Rector 0.17.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants