fix: use scope to get the correct type in ConvertEnumerableToArrayToAllRector #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdw
force-pushed
the
calebdw/push-qsvxnxkpmwwm
branch
from
8c98261 to
bd1b702
Compare
calebdw
force-pushed
the
calebdw/push-qsvxnxkpmwwm
branch
from
bd1b702 to
7a9bd2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I just PR'd larastan/larastan#2346 which allows PHPStan to understand the correct type returned from
pluck()calls. However, Rector wasn't updating any usages from->toArray()to->all(). It turns out that Rector is doing some normalization behind the scenes and the type returned from$this->getType()does not contain any generic information.Updating the rule to use
$scope->getType()fixed this issue.Thanks!