Skip to content

fix: use scope to get the correct type in ConvertEnumerableToArrayToAllRector #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2025
Merged

fix: use scope to get the correct type in ConvertEnumerableToArrayToAllRector #384

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a9bd2f
fix: use scope to get the correct type in ConvertEnumerableToArrayToA…
calebdw Sep 1, 2025
8b9cddd
Merge branch 'main' into calebdw/push-qsvxnxkpmwwm
GeniJaho Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Rector/MethodCall/ConvertEnumerableToArrayToAllRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
use PhpParser\Node\Identifier;
use PHPStan\Type\ObjectType;
use PHPStan\Type\TypeCombinator;
use Rector\PHPStan\ScopeFetcher;
use RectorLaravel\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
Expand Down Expand Up @@ -62,7 +63,12 @@ public function refactor(Node $node): ?Node
return null;
}

$type = TypeCombinator::removeNull($this->getType($node->var));
$scope = ScopeFetcher::fetch($node);
$type = TypeCombinator::removeNull(
// This HAS to use the $scope->getType() as opposed to $this->getType()
// because it's not getting the proper type from the Larastan extensions
$scope->getType($node->var)
);
$valueType = $type->getTemplateType('Illuminate\Support\Enumerable', 'TValue');

if (! (new ObjectType('Illuminate\Contracts\Support\Arrayable'))->isSuperTypeOf($valueType)->no()) {
Expand Down