fix(eslint): add parseInt to all request response checks because type coersion was removed.

Author: jthoms1

lib/cli.js

@@ -671,7 +671,7 @@ Cli.printNewsUpdates = function printNewsUpdates(skipNewsCheck) {
 
   var downloadUrl = 'http://code.ionicframework.com/content/cli-message.json';
   request({ url: downloadUrl, proxy: proxy }, function(err, res, html) {
-    if (!err && res && res.statusCode === 200) {
+    if (!err && res && parseInt(res.statusCode, 10) === 200) {
       try {
         var newsId = IonicConfig.get('newsId');
         var messagesJson = JSON.parse(html);

lib/ionic/lib.js

@@ -93,12 +93,12 @@ IonicTask.prototype.getVersionData = function(version) {
         q.reject();
         return;
       }
-      if (res.statusCode === 404) {
+      if (parseInt(res.statusCode, 10) === 404) {
         log.error('Invalid version: ' + version);
         q.reject();
         return;
       }
-      if (res.statusCode >= 400) {
+      if (parseInt(res.statusCode, 10) >= 400) {
         log.error('Unable to load version data');
         q.reject();
         return;
@@ -220,11 +220,11 @@ IonicTask.prototype.downloadZip = function(version) {
       log.error(err);
       return;
     }
-    if (res.statusCode === 404 || res.statusCode === 406) {
+    if (parseInt(res.statusCode, 10) === 404 || parseInt(res.statusCode, 10) === 406) {
       log.error('Invalid version: ' + version);
       return;
     }
-    if (res.statusCode >= 400) {
+    if (parseInt(res.statusCode, 10) >= 400) {
       log.error('Unable to download zip (' + res.statusCode + ')');
       return;
     }

lib/ionic/push.js

@@ -97,7 +97,7 @@ IonicTask.prototype.set_webhook_url = function(task, webhook_url) { // eslint-di
         return task.ionic.fail('Error setting Webhook URL: ' + err);
       }
 
-      if (response.statusCode === '200') {
+      if (parseInt(response.statusCode, 10) === '200') {
         log.info('Webhook URL set to', webhook_url);
       } else {
         return task.ionic.fail('App not found');
@@ -141,7 +141,7 @@ IonicTask.prototype.set_google_api_key = function(task, google_api_key) { // esl
         return task.ionic.fail('Error setting Google API Key: ' + err);
       }
 
-      if (response.statusCode === '200') {
+      if (parseInt(response.statusCode, 10) === '200') {
         log.info('Google API Key Saved'.green);
       } else {
         return task.ionic.fail('App not found');
@@ -232,7 +232,7 @@ IonicTask.prototype.send_push = function(task) { // eslint-disable-line camelcas
     };
 
     request(options, function(err, response) {
-      if (!err && response.statusCode === 202) {
+      if (!err && parseInt(response.statusCode, 10) === 202) {
         log.info('Successfully queued push notification');
       } else {
         log.error('Error queueing push notification', err);

lib/ionic/templates.js

@@ -23,7 +23,7 @@ IonicTask.prototype.fetchStarterTemplates = function() {
 
   var proxy = process.env.PROXY || null;
   request({ url: downloadUrl, proxy: proxy }, function(err, res, html) {
-    if (!err && res && res.statusCode === 200) {
+    if (!err && res && parseInt(res.statusCode, 10) === 200) {
       var templatesJson = {};
       try {
         templatesJson = JSON.parse(html);