Conversation
- Added a new queue-based transfer management system to handle USB endpoint transfers. - Removed bulk, interrupt, and isochronous endpoint implementations in favor of a unified queue approach. - Introduced `TransferRequest` and `TransferCompletion` types to encapsulate transfer details and results. - Updated `EndpointBase` to support queue configurations and operations. - Modified `Device` and `DeviceOp` to utilize the new queue-based endpoint retrieval. - Enhanced error handling with new error types for queue management. - Updated documentation to reflect changes in transfer handling and endpoint management.
- Updated UVC device to use synchronous endpoint retrieval instead of asynchronous. - Changed `EndpointQueue` to `Endpoint` in video streaming and transfer handling. - Refactored HubDevice to utilize `ctrl_ep_mut()` for control endpoint operations. - Modified transfer handling in the Kmod backend to support cancellation of requests. - Introduced a new `Endpoint` struct to encapsulate endpoint operations and information. - Updated the USB interface to include a new `endpoint` module for better organization. - Adjusted various backend implementations to align with the new endpoint structure. - Enhanced error handling and request validation in transfer operations.
libusb1-sys v0.7.0 moved LIBUSB_SUCCESS behind the `constants` module, making the direct path private. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EndpointQueuetrait (usb-if/src/endpoint.rs): New unified transfer API withsubmit/reclaim/poll_requestpattern, replacing per-transfer-type endpoint traits (EndpointBulkIn,EndpointBulkOut, etc.)usb-host/src/backend/ty/ep/): Consolidate bulk/interrupt/isochronous endpoint implementations into a singleEndpointstruct backed byEndpointOptrait, removing ~370 lines of duplicated codeEndpointOptrait, aligning control transfer handling across backendsUsbDevice, UVC stream, HID keyboard, and test crates to use the new queue-based APIKey Changes
EndpointBulkIn, etc.)EndpointQueuewith submit/reclaimEndpoint+EndpointInfoEndpointOpimplementationusb-if/src/endpoint.rs(329 lines)bulk.rs,int.rs,iso.rsfromty/ep/Test plan
cargo check -p crab-usb --test test --target aarch64-unknown-none-softfloatpassescargo fmt --allapplied🤖 Generated with Claude Code