Conversation
There was a problem hiding this comment.
Pull request overview
Improves ostool-server installation clarity and packaging by documenting the web UI build prerequisites and aligning systemd/service tooling with the server’s default config location.
Changes:
- Document Node.js + pnpm prerequisites for
cargo install(web UI build during crate build). - Allow systemd service write access to
/etc/ostool-server(for config creation/updates under hardened settings). - Ensure install script status messaging doesn’t corrupt the downloaded unit template output; update crate
readmepath to the crate-local README.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ostool-server/scripts/ostool-server.service |
Adds /etc/ostool-server to ReadWritePaths to support config writes under systemd sandboxing. |
ostool-server/scripts/install.sh |
Sends template-download status message to stderr so stdout remains valid unit content. |
ostool-server/README.md |
Adds explicit Node.js/pnpm prerequisite docs for successful cargo install. |
ostool-server/Cargo.toml |
Points crate metadata readme to ostool-server/README.md for correct packaging/rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.