Conversation
- Change TFTP module visibility to `pub(crate)` in `mod.rs`. - Update QEMU configuration structure to include default options and remove unnecessary layers. - Simplify QEMU run arguments and replace with a single `RunQemuOptions` struct. - Enhance U-Boot configuration handling with default values and improved loading methods. - Update `Tool` methods for loading configurations from paths and directories. - Add tests for public API to ensure proper construction and failure cases for Cargo builder and QEMU overrides. - Introduce new test cases for validating U-Boot configuration loading and default file creation.
…mprove clarity and consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.