fix(sterm): remove automatic \n to \r\n conversion in write_output#92
Merged
fix(sterm): remove automatic \n to \r\n conversion in write_output#92
Conversation
The previous implementation unconditionally converted \n to \r\n by prepending \r before each \n byte. This broke existing \r\n sequences by turning them into \r\r\n. The fix writes bytes as-is and only flushes after \n. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write_output中将\n自动转换为\r\n的逻辑\r\n序列被错误转换为\r\r\n的问题\r\n序列被正确保留Test plan
write_output_flushes_after_newlines测试验证纯\n行为不变write_output_preserves_existing_carriage_returns测试验证\r\n被保留cargo test确认全部通过🤖 Generated with Claude Code