This repository was archived by the owner on Apr 12, 2023. It is now read-only.
Speed up png reading with Cython #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
As per your suggestion in pull request #8 all the Python code necessary for the pure python version should be in one file: png.py. Then it'll be good to merge. :) That's so that the curl one-liner mentioned in the README.txt should always work. |
Owner
|
Oh yeah, I note that you and I fixed the tests in slightly different ways. If you fiddle your branch so that I can automatically merge then that'll make me 2.4% more likely to actually do it. ;) |
Contributor
Author
|
Done, let me know if it looks good now. |
drj11
added a commit
that referenced
this pull request
Sep 21, 2012
Speed up png reading with (optional) Cython
Owner
|
merged. thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an auxiliar module created with cython I managed to decode a 800x800 image in ~300ms (down from the original ~15s).