Skip to content

feat:Implemented Ask Tool#12

Merged
ayusrjn merged 1 commit into
mainfrom
dev
Apr 10, 2026
Merged

feat:Implemented Ask Tool#12
ayusrjn merged 1 commit into
mainfrom
dev

Conversation

@ayusrjn
Copy link
Copy Markdown
Member

@ayusrjn ayusrjn commented Apr 10, 2026

Summary by CodeRabbit

Release Notes

  • New Features
    • Agent now proactively asks clarifying questions when user intent is ambiguous instead of making assumptions. The agent may ask multiple questions to fully resolve uncertainty before proceeding, ensuring accurate task execution.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 10, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The changes introduce a new ask_user tool that enables the agent to clarify ambiguous user intent by asking questions, and update the system instruction to require using this tool instead of guessing when requests are unclear.

Changes

Cohort / File(s) Summary
Agent System Instructions
lambda_agent/agent.py
Updated system_instruction to explicitly authorize asking users questions and added critical directive prohibiting the agent from guessing user intent; agent must use ask_user tool to clarify ambiguities and may ask multiple questions.
User Query Tool
lambda_agent/tools.py
Added ask_user(question: str) -> str tool function that prompts the user via input() and returns their response; registered the tool in both TOOL_EXECUTORS and TOOL_FUNCTIONS for execution and schema generation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Instead of guessing what's unclear,
Our agent now can ask to hear,
The user's voice flows crystal bright,
Ambiguity's solved just right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: Implemented Ask Tool' accurately describes the main changes: adding a new ask_user tool and integrating it into the agent's system instructions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ayusrjn ayusrjn merged commit 6bf1808 into main Apr 10, 2026
2 of 3 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Apr 10, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant