Skip to content

Allow to disable proximity sensor#10

Merged
g7 merged 2 commits into
group/next/upgrade-0.44from
gnumdk/proximity
Jan 21, 2025
Merged

Allow to disable proximity sensor#10
g7 merged 2 commits into
group/next/upgrade-0.44from
gnumdk/proximity

Conversation

@bellegarde-c
Copy link
Copy Markdown
Member

The proximity sensor on Miatoll devices is not functioning properly:

  • On my test device, it freezes if monitoring starts while the sensor is covered.
  • On my main device, it freezes regardless.

These two patches provide a workaround to disable the proximity sensor:

  • When a call is answered, the device screen is turned off.
  • When the screen is turned back on, we ensure the Call UI is displayed if the call is still active.

This patch also works on devices without sensors.

I will submit these patches upstream.

Some phones may have broken proximity sensor:
- Fader is always shown
- User is forced to lock/unlock the screen to show the call ui

We allow users or device maintainers to disable proximity sensor: when a call is accepted, device is locked.
When phone has been locked while calling, we want call ui if call active.
@bellegarde-c bellegarde-c requested a review from g7 January 21, 2025 17:38
Copy link
Copy Markdown
Member

@g7 g7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@g7 g7 merged commit f16e9cf into group/next/upgrade-0.44 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants