Skip to content

Conversation

@shubham149
Copy link
Contributor

No description provided.

@bradrydzewski
Copy link
Contributor

looks good. left some minor comments.

one question I have is if we need to support these environment variables:
https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables

for the bitrise plugin we map all the harness / drone environment variables to the bitrise types:
https://github.com/drone/plugin/blob/main/plugin/bitrise/environ.go#L40

@shubham149
Copy link
Contributor Author

@bradrydzewski nektos/act sets the github environment variables. We are passing the webhook event payload json file which is parsed by the nektos to set the variables

@bradrydzewski bradrydzewski merged commit 00c8ae5 into drone:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants