Skip to content

(maint) v1.9.0 release prep#14

Merged
tphoney merged 1 commit intodrone:masterfrom
tphoney:release_prep_v1.9.0
Aug 26, 2021
Merged

(maint) v1.9.0 release prep#14
tphoney merged 1 commit intodrone:masterfrom
tphoney:release_prep_v1.9.0

Conversation

@tphoney
Copy link
Copy Markdown
Contributor

@tphoney tphoney commented Aug 26, 2021

No description provided.

Copy link
Copy Markdown

@d1wilko d1wilko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but...

I assume history.md is the old manually written changelog which is being superseded by the changelog generator

perhaps you could add some kind of note in history.md and/or the readme to confirm that as the case?

@tphoney
Copy link
Copy Markdown
Contributor Author

tphoney commented Aug 26, 2021

Looks good, but...

I assume history.md is the old manually written changelog which is being superseded by the changelog generator

perhaps you could add some kind of note in history.md and/or the readme to confirm that as the case?

https://github.com/github-changelog-generator/github-changelog-generator#migrating-from-a-manual-changelog
basically history.md is manual changelog, and it is appended to the changelog.md anyway. So nothing is lost.

Copy link
Copy Markdown

@d1wilko d1wilko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy if you're happy :)

@tphoney tphoney merged commit a355bc6 into drone:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants