Skip to content

Conversation

@mrpollo
Copy link
Member

@mrpollo mrpollo commented Feb 19, 2016

rebase of #569

@mrpollo mrpollo force-pushed the rroche/custom-mode-fix branch from 5fc7bfc to d5eeb46 Compare February 19, 2016 19:47
@tcr3dr
Copy link
Contributor

tcr3dr commented Feb 19, 2016

This lgtm, but you might want to address this:

Now that we set self._flightmode = 'AUTO' by default, there is no circumstance under which self._flightmode will be None. But we check for this in several places. Should you remove those checks?

@mrpollo
Copy link
Member Author

mrpollo commented Feb 19, 2016

I'm going to try and cleanup some of this logic I'll check for any _flightmode checks as well, we should proceed with merging this so we can unblock the px4 team

tcr3dr added a commit that referenced this pull request Feb 19, 2016
Validate existence of custom_mode before setting
@tcr3dr tcr3dr merged commit 3d377f4 into master Feb 19, 2016
@tcr3dr tcr3dr deleted the rroche/custom-mode-fix branch February 19, 2016 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants