Skip to content

feat: Implement xsd:negativeInteger codec#74

Merged
mark-dropbear merged 2 commits intomainfrom
negint
Nov 27, 2025
Merged

feat: Implement xsd:negativeInteger codec#74
mark-dropbear merged 2 commits intomainfrom
negint

Conversation

@mark-dropbear
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mark-dropbear, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces full support for the xsd:negativeInteger data type, enhancing the library's capability to handle XML Schema data. It provides robust encoding and decoding mechanisms for negative integer values, ensuring data integrity and compliance with XSD standards.

Highlights

  • New Codec Implementation: Implemented a new codec for the xsd:negativeInteger XML Schema Definition (XSD) data type, enabling proper encoding and decoding of negative integer values.
  • Documentation Update: Updated README.md to reflect the full support for xsd:negativeInteger and added an entry to CHANGELOG.md.
  • Comprehensive Testing: Included dedicated unit tests for the XsdNegativeIntegerCodec to ensure its correctness and adherence to XSD specifications, covering valid and invalid inputs for both encoding and decoding.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a codec for xsd:negativeInteger, including the encoder, decoder, and corresponding tests. The implementation is well-structured and follows the existing patterns in the codebase. The logic for validation in both the encoder and decoder is correct according to the XSD specification for negative integers. I've added one suggestion to enhance the test coverage for invalid inputs, which would make the implementation even more robust. Overall, this is a great addition to the library.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@mark-dropbear mark-dropbear merged commit ae7fe9d into main Nov 27, 2025
1 check passed
@mark-dropbear mark-dropbear deleted the negint branch November 27, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant