Skip to content

Upgrade Gradle Plugin so we can have knowledge of how to disable config cache #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2022
Merged

Upgrade Gradle Plugin so we can have knowledge of how to disable config cache #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7209e71
Upgrade Gradle Plugin so we can have knowledge of how to disable conf…
joshafeinberg Jul 7, 2022
7f9c1db
Get off RC
joshafeinberg Jul 7, 2022
9c5040e
PR Comments
joshafeinberg Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...tector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleDetectorPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import org.gradle.api.Project
import org.gradle.api.Task
import org.gradle.api.tasks.testing.Test
import org.gradle.internal.impldep.org.jetbrains.annotations.VisibleForTesting
import org.gradle.util.GradleVersion

/**
* This plugin creates and registers all affected test tasks.
Expand Down Expand Up @@ -95,6 +96,7 @@ class AffectedModuleDetectorPlugin : Plugin<Project> {
val task = rootProject.tasks.register(taskType.commandByImpact).get()
task.group = CUSTOM_TASK_GROUP_NAME
task.description = taskType.taskDescription
disableConfigCache(task)

rootProject.subprojects { project ->
pluginIds.forEach { pluginId ->
Expand Down Expand Up @@ -125,6 +127,7 @@ class AffectedModuleDetectorPlugin : Plugin<Project> {
)
}

@Suppress("UnstableApiUsage")
@VisibleForTesting
internal fun registerInternalTask(
rootProject: Project,
Expand All @@ -134,6 +137,7 @@ class AffectedModuleDetectorPlugin : Plugin<Project> {
val task = rootProject.tasks.register(taskType.commandByImpact).get()
task.group = groupName
task.description = taskType.taskDescription
disableConfigCache(task)

rootProject.subprojects { project ->
project.afterEvaluate {
Expand All @@ -150,6 +154,12 @@ class AffectedModuleDetectorPlugin : Plugin<Project> {
}
}

private fun disableConfigCache(task: Task) {
if (GradleVersion.current() >= GradleVersion.version("7.4")) {
task.notCompatibleWithConfigurationCache("AMD requires knowledge of what has changed in the file system so we can not cache those values (https://github.com/dropbox/AffectedModuleDetector/issues/150)")
}
}

private fun withPlugin(
pluginId: String,
task: Task,
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4.2-bin.zip
2 changes: 1 addition & 1 deletion sample/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4.2-all.zip