Skip to content

Small refactoring #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Small refactoring #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions ...duledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleDetector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,16 +362,15 @@ class AffectedModuleDetectorImpl constructor(
private var unknownFiles: MutableSet<String> = mutableSetOf()

override fun shouldInclude(project: Project): Boolean {
return (
(project.isRoot || (
affectedProjects.contains(project) &&
isProjectProvided2(project)
)) && !config.excludedModules.contains(project.name)
).also {
logger?.info(
"checking whether I should include ${project.path} and my answer is $it"
)
}
val isRootProject = project.isRoot
val isProjectAffected = affectedProjects.contains(project)
val isProjectProvided = isProjectProvided2(project)
val isNotModuleExcluded = !config.excludedModules.contains(project.name)

val shouldInclude = (isRootProject || (isProjectAffected && isProjectProvided)) && isNotModuleExcluded
logger?.info("checking whether I should include ${project.path} and my answer is $shouldInclude")

return shouldInclude
}

override fun hasAffectedProjects() = affectedProjects.isNotEmpty()
Expand Down