Correcting the spelling of the principal username in the Presto client.#326
Merged
bkyryliuk merged 1 commit intodropbox:masterfrom Apr 16, 2020
Merged
Correcting the spelling of the principal username in the Presto client.#326bkyryliuk merged 1 commit intodropbox:masterfrom
bkyryliuk merged 1 commit intodropbox:masterfrom
Conversation
… `principal_username`.
1 task
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 14 14
Lines 1526 1526
Branches 165 165
=======================================
Hits 1423 1423
Misses 75 75
Partials 28 28
Continue to review full report at Codecov.
|
Contributor
|
@Ralnoc this is good enough. I'll add note to the release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correcting the spelling in the presto.py from
principle_usernametoprincipal_username.Please let me know if we need to retain the original variable for backwards compatibility and I'll update the PR accordingly.