Add prefix to distinguish multiple auth variants of builders #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiuyangzhao
suggested changes
Nov 21, 2019
generator/java.stoneg.py
Outdated
| prefix = self._args.requests_classname_prefix or self._args.client_class | ||
| package = self.java_class(route).package | ||
| return JavaClass(package + '.' + classname(format_func_name(route) + '_builder')) | ||
| return JavaClass(package + '.' + classname( |
Contributor
There was a problem hiding this comment.
I think this is backward-incompatible. Like GetMetadataBuilder will become DbxUserGetMetadataBuilder. It would be great if we add prefix only for routes with multiple auth
jiuyangzhao
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the previous change, code may now be generated for endpoints with multiple authentication types. If an endpoint with multiple authentication types generates a
Builder, this causes a naming collision and compilation error as we attempt to generate multiple builders with the same nameThis change uses the existing prefix that was already applied to the
Requestsclasses toBuilders to avoid this issueIt is a breaking change for existing consumers though the effect is minimal as it only affects places where the calling code makes explicit reference to the builder's type