Add type to ColumnOperators startswith's parameter other #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
approved these changes
Oct 2, 2019
Contributor
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thanks, LGTM! Could you please sign the CLA? (link at the bottom of README) Let me know when you will sign it so I can merge this.
Contributor
|
Hi @ilevkivskyi , @slaroche is contributing as part of Flare Systems team, I did sign the Corporation CLA. |
isra17
reviewed
Oct 2, 2019
| def is_(self, other): ... | ||
| def isnot(self, other): ... | ||
| def startswith(self, other, **kwargs): ... | ||
| def startswith(self, other: str, **kwargs): ... |
Contributor
There was a problem hiding this comment.
Might be useful to add other: str to the following string methods in this PR?
Contributor
There was a problem hiding this comment.
It is better to make a separate PR, I will merge this one now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type
strtoColumnOperators.startswith's parameterother