Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type to ColumnOperators startswith's parameter other #110

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@samlaroche
Copy link
Contributor

samlaroche commented Sep 30, 2019

Add type str to ColumnOperators.startswith's parameter other

Copy link
Collaborator

ilevkivskyi left a comment

Thanks, LGTM! Could you please sign the CLA? (link at the bottom of README) Let me know when you will sign it so I can merge this.

@isra17

This comment has been minimized.

Copy link
Contributor

isra17 commented Oct 2, 2019

Hi @ilevkivskyi , @slaroche is contributing as part of Flare Systems team, I did sign the Corporation CLA.

@@ -46,7 +46,7 @@ class ColumnOperators(Operators):
def notilike(self, other, escape: Optional[Any] = ...): ...
def is_(self, other): ...
def isnot(self, other): ...
def startswith(self, other, **kwargs): ...
def startswith(self, other: str, **kwargs): ...

This comment has been minimized.

Copy link
@isra17

isra17 Oct 2, 2019

Contributor

Might be useful to add other: str to the following string methods in this PR?

This comment has been minimized.

Copy link
@ilevkivskyi

ilevkivskyi Oct 2, 2019

Collaborator

It is better to make a separate PR, I will merge this one now.

@ilevkivskyi ilevkivskyi merged commit 71bb32a into dropbox:master Oct 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.