Skip to content

Add type to ColumnOperators startswith's parameter other #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Add type to ColumnOperators startswith's parameter other #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlalchemy-stubs/sql/operators.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class ColumnOperators(Operators):
def notilike(self, other, escape: Optional[Any] = ...): ...
def is_(self, other): ...
def isnot(self, other): ...
def startswith(self, other, **kwargs): ...
def startswith(self, other: str, **kwargs): ...
Copy link
Contributor

@isra17 isra17 Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be useful to add other: str to the following string methods in this PR?

Copy link
Contributor

@ilevkivskyi ilevkivskyi Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to make a separate PR, I will merge this one now.

def endswith(self, other, **kwargs): ...
def contains(self, other, **kwargs): ...
def match(self, other, **kwargs): ...
Expand Down