A bunch or minor fixes and temporary things #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kespindler
pushed a commit
to januarytech/sqlalchemy-stubs
that referenced
this pull request
Feb 2, 2019
Fixes dropbox#50 The goal is mostly to simplify the sync with our internal code. There are two changes that are going to be reverted soon: * Type engine parameter for `String` should actually be `Text`, it is set to `str` temporarily for short transition period. It will be reverted back to `Text` before the release. * The two lenient overloads in `Column.__init__()` are temporarily added to suppress some errors. They will be also removed before the release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50
The goal is mostly to simplify the sync with our internal code. There are two changes that are going to be reverted soon:
Stringshould actually beText, it is set tostrtemporarily for short transition period. It will be reverted back toTextbefore the release.Column.__init__()are temporarily added to suppress some errors. They will be also removed before the release.