Skip to content

Commit 12dda16

Browse files
committed
Change RedirectView permanent to status_code
1 parent 3b9ca71 commit 12dda16

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

plain/plain/views/redirect.py

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
1-
from plain.http import (
2-
ResponsePermanentRedirect,
3-
ResponseRedirect,
4-
)
1+
from plain.http import ResponseRedirect
52
from plain.urls import reverse
63

74
from .base import View
@@ -10,17 +7,17 @@
107
class RedirectView(View):
118
"""Provide a redirect on any GET request."""
129

13-
permanent = False
10+
status_code = 302
1411
url: str | None = None
1512
url_name: str | None = None
1613
preserve_query_params = False
1714

1815
def __init__(
19-
self, url=None, permanent=None, url_name=None, preserve_query_params=None
16+
self, url=None, status_code=None, url_name=None, preserve_query_params=None
2017
):
21-
# Allow attributes to be set in RedirectView.as_view(url="...", permanent=True, etc.)
18+
# Allow attributes to be set in RedirectView.as_view(url="...", status_code=301, etc.)
2219
self.url = url or self.url
23-
self.permanent = permanent if permanent is not None else self.permanent
20+
self.status_code = status_code if status_code is not None else self.status_code
2421
self.url_name = url_name or self.url_name
2522
self.preserve_query_params = (
2623
preserve_query_params
@@ -48,10 +45,7 @@ def get_redirect_url(self):
4845

4946
def get(self):
5047
url = self.get_redirect_url()
51-
if self.permanent:
52-
return ResponsePermanentRedirect(url)
53-
else:
54-
return ResponseRedirect(url)
48+
return ResponseRedirect(url, status_code=self.status_code)
5549

5650
def head(self):
5751
return self.get()

0 commit comments

Comments
 (0)