Type annotations for plain-code

Author: davegaeddert

plain-code/plain/code/biome.py

@@ -153,7 +153,7 @@ def install(self, version: str = "") -> str:
         self.set_version_in_config(v)
         return v
 
-    def invoke(self, *args, cwd=None) -> subprocess.CompletedProcess:
+    def invoke(self, *args: str, cwd: str | None = None) -> subprocess.CompletedProcess:
         # Run the standalone biome binary with given args
         config_path = os.path.abspath(
             os.path.join(os.path.dirname(__file__), "biome_defaults.json")

plain-code/plain/code/cli.py

@@ -1,7 +1,10 @@
+from __future__ import annotations
+
 import subprocess
 import sys
 import tomllib
 from pathlib import Path
+from typing import Any
 
 import click
 
@@ -15,15 +18,15 @@
 
 @register_cli("code")
 @click.group()
-def cli():
+def cli() -> None:
     """Code formatting and linting"""
     pass
 
 
 @cli.command()
 @click.option("--force", is_flag=True, help="Reinstall even if up to date")
 @click.pass_context
-def install(ctx, force):
+def install(ctx: click.Context, force: bool) -> None:
     """Install or update the Biome standalone per configuration."""
     config = get_code_config()
 
@@ -50,7 +53,7 @@ def install(ctx, force):
 
 
 @cli.command()
-def update():
+def update() -> None:
     """Update the Biome standalone binary to the latest release."""
     config = get_code_config()
 
@@ -67,7 +70,7 @@ def update():
 @cli.command()
 @click.pass_context
 @click.argument("path", default=".")
-def check(ctx, path):
+def check(ctx: click.Context, path: str) -> None:
     """Check the given path for formatting or linting issues."""
     ruff_args = ["--config", str(DEFAULT_RUFF_CONFIG)]
     config = get_code_config()
@@ -103,7 +106,7 @@ def check(ctx, path):
 @click.argument("path", default=".")
 @click.option("--unsafe-fixes", is_flag=True, help="Apply ruff unsafe fixes")
 @click.option("--add-noqa", is_flag=True, help="Add noqa comments to suppress errors")
-def fix(ctx, path, unsafe_fixes, add_noqa):
+def fix(ctx: click.Context, path: str, unsafe_fixes: bool, add_noqa: bool) -> None:
     """Lint and format the given path."""
     ruff_args = ["--config", str(DEFAULT_RUFF_CONFIG)]
     config = get_code_config()
@@ -153,7 +156,7 @@ def fix(ctx, path, unsafe_fixes, add_noqa):
             sys.exit(result.returncode)
 
 
-def get_code_config():
+def get_code_config() -> dict[str, Any]:
     pyproject = Path("pyproject.toml")
     if not pyproject.exists():
         return {}

plain-code/plain/code/entrypoints.py

@@ -1,4 +1,4 @@
-def setup():
+def setup() -> None:
     # This package isn't an installed app,
     # so we need to trigger our own import and cli registration.
     from .cli import cli  # noqa

scripts/type-validate

@@ -18,6 +18,7 @@ FULLY_TYPED_DIRS = [
     "plain-api/plain/api",
     "plain-auth/plain/auth",
     "plain-cache/plain/cache",
+    "plain-code/plain/code",
     "plain-sessions/plain/sessions",
 ]