Fix INSTALLED_PACKAGES not being optional in user settings

davegaeddert · davegaeddert · commit 820773c4730e · 2026-01-13T21:01:43.000-06:00
Restores getattr with default empty list, which was accidentally changed to direct attribute access in ac1eeb0.
diff --git a/plain/plain/runtime/user_settings.py b/plain/plain/runtime/user_settings.py
@@ -113,7 +113,7 @@ def _load_module_settings(self, module: types.ModuleType) -> None:
                 )
 
     def _load_default_settings(self, settings_module: types.ModuleType) -> None:
-        for entry in settings_module.INSTALLED_PACKAGES:
+        for entry in getattr(settings_module, "INSTALLED_PACKAGES", []):
             if isinstance(entry, PackageConfig):
                 app_settings = entry.module.default_settings
             elif find_spec(f"{entry}.default_settings"):

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ def _load_module_settings(self, module: types.ModuleType) -> None:`
`113`	`113`	`)`
`114`	`114`
`115`	`115`	`def _load_default_settings(self, settings_module: types.ModuleType) -> None:`
`116`		`- for entry in settings_module.INSTALLED_PACKAGES:`
	`116`	`+ for entry in getattr(settings_module, "INSTALLED_PACKAGES", []):`
`117`	`117`	`if isinstance(entry, PackageConfig):`
`118`	`118`	`app_settings = entry.module.default_settings`
`119`	`119`	`elif find_spec(f"{entry}.default_settings"):`