Commit a44e5ec
committed
Replace auto_now + default=Now/GenRandomUUID with type-scoped kwargs
DB-default behavior was overloaded onto `default=` via a generic
`DatabaseDefaultExpression` marker. Users wrote `default=Now()` on
DateTimeField and `default=GenRandomUUID()` on UUIDField, and nothing
stopped `default=Now()` from being typed on an IntegerField. This
change narrows the surface to each field type's actual use case:
- DateTimeField(create_now=True) — DB STATEMENT_TIMESTAMP() on INSERT
- DateTimeField(update_now=True) — Python pre_save, fires on every save
- UUIDField(generate=True) — DB gen_random_uuid() on INSERT
`default=` is removed entirely from DateTimeField and UUIDField.
DateField/TimeField keep `default=` and drop the rarely-useful `auto_now`.
`Now()` and `GenRandomUUID()` stay exported for use in annotations and
filters; they're no longer valid as `default=` values.
Internal cleanup:
- `DatabaseDefaultExpression` marker class deleted; `Now`/`GenRandomUUID`
are plain `Func` subclasses.
- `_db_default_expression` moved off `self.default` onto a per-field
`cached_property`; expression construction is derived from the boolean
kwarg.
- `has_db_default()` routes through a new `get_db_default_expression()`
method on Field; `db_returning` is now a property that delegates to it.
- `auto_fills_on_save` property on Field lets full_clean and the
autodetector skip validation/backfill for pre_save-filled fields.
- `has_any_default()` consolidates the three-way predicate used by
autodetector guards and the schema editor's four-way backfill gate.
- DateTimeField no longer inherits from DateField; temporal lookups
(ExtractYear/Month/Day/etc.) are registered on DateTimeField
explicitly, and TruncBase/CombinedExpression isinstance checks now
include DateTimeField.
- UUIDField inherits from ColumnField (not DefaultableField).
All shipped model fields and migrations are converted to the new API.
The plainmigrations recorder uses `update_now=True` (not `create_now=True`)
because ensure_schema() skips tables that already exist — existing
installations wouldn't gain the DB default.1 parent 90142f5 commit a44e5ec
56 files changed
Lines changed: 635 additions & 496 deletions
File tree
- example/app
- notes
- migrations
- users
- migrations
- plain-admin/plain/admin
- migrations
- plain-api/plain/api
- migrations
- plain-auth/plain/auth
- plain-cache/plain/cache
- migrations
- plain-flags/plain/flags
- migrations
- plain-jobs/plain/jobs
- migrations
- plain-oauth/plain/oauth
- migrations
- plain-pageviews/plain/pageviews
- migrations
- plain-postgres
- plain/postgres
- convergence
- fields
- functions
- migrations
- sql
- tests
- app/examples
- migrations
- models
- plain-redirection/plain/redirection
- migrations
- plain-sessions/plain/sessions
- migrations
- plain-support/plain/support
- migrations
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
35 | 34 | | |
36 | 35 | | |
37 | 36 | | |
| |||
40 | 39 | | |
41 | 40 | | |
42 | 41 | | |
43 | | - | |
| 42 | + | |
44 | 43 | | |
45 | 44 | | |
46 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
19 | 18 | | |
20 | 19 | | |
21 | 20 | | |
22 | | - | |
| 21 | + | |
23 | 22 | | |
24 | | - | |
| 23 | + | |
25 | 24 | | |
26 | 25 | | |
27 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
| |||
18 | 17 | | |
19 | 18 | | |
20 | 19 | | |
21 | | - | |
22 | | - | |
| 20 | + | |
| 21 | + | |
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
17 | | - | |
| 16 | + | |
18 | 17 | | |
19 | 18 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
16 | | - | |
| 15 | + | |
17 | 16 | | |
18 | 17 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
18 | 17 | | |
19 | 18 | | |
20 | 19 | | |
21 | | - | |
| 20 | + | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
| |||
17 | 16 | | |
18 | 17 | | |
19 | 18 | | |
20 | | - | |
| 19 | + | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | 3 | | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
8 | | - | |
9 | 7 | | |
10 | 8 | | |
11 | 9 | | |
| |||
18 | 16 | | |
19 | 17 | | |
20 | 18 | | |
21 | | - | |
22 | | - | |
23 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
24 | 22 | | |
25 | 23 | | |
26 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
11 | | - | |
12 | 10 | | |
13 | 11 | | |
14 | 12 | | |
| |||
19 | 17 | | |
20 | 18 | | |
21 | 19 | | |
22 | | - | |
23 | | - | |
24 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
25 | 23 | | |
26 | 24 | | |
27 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
80 | 79 | | |
81 | 80 | | |
82 | 81 | | |
| |||
85 | 84 | | |
86 | 85 | | |
87 | 86 | | |
88 | | - | |
| 87 | + | |
89 | 88 | | |
90 | 89 | | |
91 | 90 | | |
| |||
0 commit comments