This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Notifications with badges #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celian-rib
suggested changes
Sep 22, 2022
Closed
celian-rib
approved these changes
Nov 12, 2022
Member
celian-rib
left a comment
celian-rib
left a comment
There was a problem hiding this comment.
Pour moi c'est bon mais jaimerai une validation avec un tests sur l'appli avant de merge.
@tjobit est-ce que tu pourrais check maintenant que tu as les 2 projets en local ? :)
On pourra valider et merger comme ca
celian-rib
suggested changes
Nov 13, 2022
Member
There was a problem hiding this comment.
@killian-mannarelli les badges fonctionnent nickels mais sur les notifs de messages il y a que le titre et plus les contenu du message
celian-rib
suggested changes
Nov 18, 2022
Member
celian-rib
left a comment
celian-rib
left a comment
There was a problem hiding this comment.
Bon j'ai teste et ca marche, donc c'etait surrement un probleme en local sur mon setup, faut juste clean les 2 trucs et c'est good
| import { decryptMessage } from '@/utils/encrypt'; | ||
| import { SimplifiedDropy } from '@/interfaces/dropy.interface'; | ||
| import { incrementUserBadgeNotification } from './user.socket.service'; | ||
| import { Console } from 'console'; |
Contributor
Author
There was a problem hiding this comment.
Fail d'écriture, en gros c'est une habitude de C# où Console est en maj
| }, | ||
| }); | ||
| const decryptMessageContent = decryptMessage(content); | ||
| console.log('decryptMessageContent', decryptMessageContent); |
celian-rib
approved these changes
Nov 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Le badge (petit cercle rouge avec le nombre de notifs) étant 100% server-side on doit gérer plusieurs choses :
-Ajout en BD du nombre de notifs pour le badge.
-Une méthode dans le socket pour incrémenter ce nombre (pas dans notifications.ts pour éviter les dépendances à un service)
-Une autre méthode pour remettre à zéro à l'ouverture de l'app (pour moi à la connection au socket)
NB : Dans le User.service il n'y a pas d'appel à la méthode du socket service pour éviter les dépendances.
(A TESTER AVANT DE DEPLOY)
#73