Skip to content

Deploy to github pages#3

Merged
ChenPeleg merged 26 commits into
productionfrom
preview
Apr 24, 2025
Merged

Deploy to github pages#3
ChenPeleg merged 26 commits into
productionfrom
preview

Conversation

@ChenPeleg
Copy link
Copy Markdown
Collaborator

No description provided.

@ChenPeleg ChenPeleg requested a review from Copilot April 24, 2025 14:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes several changes to support deployment to GitHub Pages by updating test files, modifying Firebase integration to use a provider abstraction, and updating several course lesson markdown files for improved clarity and formatting. Key changes include:

  • Updates to tests in Checkout and AppHeader to improve UI text handling and add new coverage for order submission scenarios.
  • Refactoring of Firebase calls in OrdersHistory and Checkout to delegate to a new firebaseProvider.
  • Extensive reformatting and content updates in many lesson markdown files.

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/appHeader.test.jsx Adjusted the expected label on order history links for improved i18n handling.
tests/Checkout.test.jsx Added additional tests and updated imports; note there is a potential context order issue.
src/pages/OrdersHistory.jsx Replaced direct Firebase calls with firebaseProvider and modified markup; check console.log usage.
src/pages/Checkout.jsx Updated Firebase calls and layout adjustments including order merging with cart items.
src/firebase/firebaseProvider.js Introduced a provider that conditionally uses local storage in production.
src/components/AppHeader.tsx Improved responsive navigation layout and styling adjustments.
lessons/*.md Various content reformatting and minor corrections to course lesson files.
Comments suppressed due to low confidence (2)

tests/Checkout.test.jsx:230

  • The baseMockContext is defined after its usage in the test suites, which could lead to reference errors. Consider moving its declaration above the tests that reference it.
const baseMockContext = { cart: [ ... ], setCart: vi.fn(), isAuth: false, setIsAuth: (value) => { } }

src/pages/OrdersHistory.jsx:13

  • This logging statement is incomplete and currently does nothing. Either remove it or update it to log relevant data.
console.log

@ChenPeleg ChenPeleg merged commit 018c919 into production Apr 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants