Improve exec hook output/behavior, fixes #1818, fixes #1765#1860
Merged
Conversation
Member
Author
|
Artifacts are at https://circleci.com/gh/drud/ddev/18254#artifacts/containers/0 |
Contributor
|
This is a very nice improvement! |
e626744 to
9c4770b
Compare
mostly for tests
9c4770b to
fdaedde
Compare
Member
Author
|
Rebased and retested; I think this is ready to go when tests pass. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
#1818 points out that there are cases where an exec task fails and no output is provided
#1765 requests clearer feedback about the problem when an exec task fails, instead of giving a bunch of docker-compose gobbledygook.
How this PR Solves The Problem:
Manual Testing Instructions:
Try this in your config.yaml:
and do a
ddev startls junker99should fail with appropriate informationAutomated Testing Overview:
No new testing is added here.
Related Issue Link(s):
#1818
#1765
Release/Deployment notes:
Add to release notes: